Skip to content

fix(visualize): resolve crashes and blank L1 weight plots #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
barnaby-wreford wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(visualize): resolve crashes and blank L1 weight plots #320

barnaby-wreford wants to merge 2 commits into from

Conversation

@barnaby-wreford
Copy link

@barnaby-wreford barnaby-wreford commented Jun 23, 2025

Summary

Fixes multiple bugs in visualize.py that caused immediate crashes and blank plots.

Changes

  • Corrected usage of self.model.num_ls_buckets instead of self.model.feature_set.num_ls_buckets.
  • Fixed out-of-bounds indexing error when retrieving L1 weights.
  • Added truncation of L1 weights to prevent matshow from rendering blank plots/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@barnaby-wreford