introduce skip early plies parameter #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disservin
force-pushed
the
param-skip_early_plies
branch
from
a16a1a7 to
696135d
Compare
Member
|
I'm more inclined towards this generalized version. Will review tomorrow. |
Member
|
Okay, I think the only issue right now is the parameter order is inconsistent. Either always put it before param index or after. Eventually it's gonna need replacing with a struct because there's quite a lot of parameters right now, but for now at least let's not mess this up further. |
Member
Author
|
Ah yeah the order was messed up also the parameter was missing in some places, using a struct is definitely a good idea, or even some json config file perhaps? |
Member
|
Not mutually exclusive |
linrock
reviewed
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert the static value used in official-stockfish/Stockfish#4314 into a parameter
would be cool if someone could test this since I have no idea how to run pytorch ^^