Skip all positions with ply less than or equal to 28 #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linrock
commented
Dec 30, 2022
| if (e.score == VALUE_NONE) | ||
| return true; | ||
|
|
||
| if (e.ply <= 28) // TODO enable setting ply count via a runtime flag |
Contributor
Author
There was a problem hiding this comment.
maybe something like --early-ply-skipping 28
Member
|
Hi, I think I added that functionality master...Disservin:nnue-pytorch:param-skip_early_plies would be cool if someone could test this since I have no idea how to run pytorch ^^ I can make a pr if you want or you can also copy the changes since its your idea anyway ; ) |
Contributor
Author
|
cool, feel free to open a PR since you've written the code already. easier to discuss the changes there |
Contributor
Author
|
closing in favor of the configurable param approach in #222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification was used to train the net in official-stockfish/Stockfish#4314