Add a way to disable factorization #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sopel97
commented
Jul 1, 2021
| import torch | ||
|
|
||
| def NnueOptimizer(optimizer_cls, params, **kwargs): | ||
| class SpecificNnueOptimizer(optimizer_cls): |
Member
Author
There was a problem hiding this comment.
if anyone has an idea how to do this part better I'd be happy to know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a way to disable factorization of the L1 and the FT layer. Currently it's only possible from the code, with no option exposed to the user. A wrapper is introduced for the optimizer to handle partial layer masks; in the future weight clipping should be moved there.