Allow ip address of worker to change during a task. #2417
Merged
+14
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that this happens more than expected.
There was a problem hiding this comment.
Pull request overview
This PR allows workers to change their IP address during task execution. The changes remove the IP address validation check when workers submit task updates, while preserving the original IP address for connection tracking purposes.
Key Changes
- Remove
remote_addrfrom task validation, allowing workers to submit updates from different IP addresses - Preserve the original IP address in task data to maintain accurate connection tracking
- Enhance error logging in connection management to include action database logging
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/fishtest/api.py | Removes IP address validation for task updates and implements logic to preserve the original IP address when a task exists |
| server/fishtest/rundb.py | Adds action database logging for connection deletion errors to improve debugging capabilities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ppigazzini
approved these changes
Dec 19, 2025
Collaborator
ppigazzini
left a comment
ppigazzini
left a comment
There was a problem hiding this comment.
Looks good on DEV, PROD update after merging, thank you @vdbergh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that this happens more than expected.