Handle EXIT_SUCCESS and EXIT_FAILURE in format_returncode(). #2414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppigazzini
added
enhancement
worker update
Raise worker version to 305 (also server side).
ppigazzini
force-pushed
the
EXIT_CODE
branch
from
8923b0a to
b482bb5
Compare
There was a problem hiding this comment.
Pull request overview
This PR improves error message readability by making format_returncode() return human-readable strings ("EXIT_SUCCESS" and "EXIT_FAILURE") instead of numeric codes for common return values 0 and 1. The change is cosmetic and aimed at making error messages more understandable when displayed on the testing interface.
- Enhanced
format_returncode()to handle EXIT_SUCCESS (0) and EXIT_FAILURE (1) explicitly with named constants - Bumped WORKER_VERSION from 304 to 305 to track the change
- Updated file integrity hashes in sri.txt to reflect the modified worker.py and games.py
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| worker/games.py | Modified format_returncode() to return "EXIT_SUCCESS" for code 0, "EXIT_FAILURE" for code 1, and reorganized condition order for clarity |
| worker/worker.py | Incremented WORKER_VERSION constant from 304 to 305 |
| server/fishtest/api.py | Incremented WORKER_VERSION constant from 304 to 305 to stay in sync with worker |
| worker/sri.txt | Updated file integrity hashes for worker.py and games.py to reflect code changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ppigazzini
approved these changes
Dec 11, 2025
Collaborator
ppigazzini
left a comment
ppigazzini
left a comment
There was a problem hiding this comment.
Looks good in linux, wsl2, msys2 workers. PROD update after merging, thank you @vdbergh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a small cosmetic change. It would make the error message here
https://tests.stockfishchess.org/actions?max_actions=1&action=&user=&text=fastchess&before=1765303442.779962&run_id=
look somewhat nicer.