Default LTC SPSA throughput to 50% #2407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds automatic throughput adjustment for LTC SPSA tests. When a user selects an LTC test type with SPSA stopping rule, the throughput is automatically set to 50%. When switching away from SPSA, the throughput is restored to the LTC default of 100%.
Key changes:
- Added
handleLtcSpsaThroughput()function to manage throughput based on test type and stop rule combination - Integrated the function into test type and stop rule change event handlers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ppigazzini
approved these changes
Nov 5, 2025
Collaborator
ppigazzini
left a comment
ppigazzini
left a comment
There was a problem hiding this comment.
Looks good on DEV, thank you @FauziAkram
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default LTC SPSA throughput to 50%
This pull request updates the "Create New Test" page to automatically set the default Throughput to 50% when a user selects the LTC (Long Time Control) test type in combination with the SPSA.
Motivation:
The current standard practice within the Stockfish community for SPSA tuning tests at LTC, is to run them at 50% throughput. Developers currently have to remember to manually change this setting from the 100% default every time they launch a new LTC SPSA test.
This change automates that step, aligning Fishtest's default behavior with community best practices and improving the user experience for developers.