Update memory estimates #2404
Merged
Update memory estimates #2404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a pending SF patch requires an update of the memory estimate official-stockfish/Stockfish#6350
ppigazzini
added
worker update
There was a problem hiding this comment.
Pull Request Overview
This PR updates memory estimates for Stockfish worker processes to reflect changes in a pending Stockfish patch. The per-thread memory requirement increases from 16 MB to 31 MB, necessitating updates to worker version numbers and memory calculations across worker and server components.
Key changes:
- Increased per-thread memory estimate from 16 to 31 MB in memory calculations
- Bumped worker version from 300 to 301 across both worker and server code
- Updated integrity hashes in sri.txt to reflect the modified worker.py file
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| worker/worker.py | Updated worker version to 301 and modified per-thread memory estimate from 16 to 31 in STC_memory calculation |
| worker/sri.txt | Updated version and hash values for worker.py to reflect the code changes |
| server/fishtest/rundb.py | Updated per-thread memory estimate from 16 to 31 in server-side memory calculation |
| server/fishtest/api.py | Updated worker version constant from 300 to 301 to match worker changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ppigazzini
approved these changes
Oct 12, 2025
Collaborator
ppigazzini
left a comment
ppigazzini
left a comment
There was a problem hiding this comment.
Looks good on DEV with linux/wsl2/msys2 workers, PROD update after merging, thank you @vondele
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a pending SF patch requires an update of the memory estimate
official-stockfish/Stockfish#6350