Skip to content

Conversation

@VoyagerOne
Copy link
Contributor

Simplify TT penalty stat

STC:
LLR: 2.95 (-2.94,2.94) [-3.00,1.00]
Total: 20251 W: 3692 L: 3570 D: 12989

LTC:
LLR: 2.95 (-2.94,2.94) [-3.00,1.00]
Total: 16432 W: 2155 L: 2029 D: 12248

Simplify TT penalty stat
@MichaelB7
Copy link
Contributor

This is not a simplification, search is changing as evidence by the change in the bench count, further it is described as penalty for failing low, but the failing low criteria has been removed. It should be tested at 5 0.

@Rocky640
Copy link

@ MichaelB7: a simplification is a removal of code. It may change the bench count, or it may not,

Usually it changes the bench count, and [-3, 1] is the appropriate bound in that case, as you can see in other pull requests that were accepted.

@lucasart
Copy link

Original "fail low" condition was wrong. Fail low is <= alpha, not < alpha. Better without this condition than with one that doesn't make sense. I think this patch should be merged. Of course, the comment needs updating.

@mcostalba mcostalba merged commit fa24cc2 into official-stockfish:master Jan 29, 2017
IIvec referenced this pull request in IIvec/Stockfish Jan 29, 2017
Simplify TT penalty stat (#980)
@VoyagerOne VoyagerOne deleted the ttStat branch June 10, 2017 17:49
MichaelB7 pushed a commit to MichaelB7/Stockfish that referenced this pull request Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants