Prefer operator<<() to pretty() #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is more idiomatic, we didn't used it in the past because Position::pretty(Move) had a calling argument, but now we can. As an added benefit, we avoid a lot of string copies in the process because now we avoid std::ostringstream ss. No functional change.
|
Approved |
Contributor
|
Looks good, push away. |
mcostalba
added a commit
that referenced
this pull request
Nov 1, 2014
Prefer operator<<() to pretty() No functional change.
niklasf
pushed a commit
to niklasf/Stockfish
that referenced
this pull request
Oct 31, 2016
Bugfix for horde games with reverse colors
Alayan-stk-2
added a commit
to Alayan-stk-2/Stockfish
that referenced
this pull request
Feb 3, 2020
…nvert. This patch looks for some common features related to conversion chances in order to better separate drawish endgames from winnable endgames. (official-stockfish#89) Original idea from Stockfish, whose initiative code served as a base to simplify and adapt to Ethereal. ELO | 6.65 +- 4.59 (95%) SPRT | 10.0+0.1s Threads=1 Hash=8MB LLR | 2.95 (-2.94, 2.94) [0.00, 5.00] Games | N: 8825 W: 1861 L: 1692 D: 5272 http://chess.grantnet.us/viewTest/3471/ ELO | 12.01 +- 6.05 (95%) SPRT | 60.0+0.6s Threads=1 Hash=64MB LLR | 2.96 (-2.94, 2.94) [0.00, 5.00] Games | N: 3965 W: 690 L: 553 D: 2722 http://chess.grantnet.us/viewTest/3472/ BENCH: 7,303,371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is more idiomatic, we didn't used it
in the past because Position::pretty(Move)
had a calling argument, but now we can.
As an added benefit, we avoid a lot of string
copies in the process because now we avoid
std::ostringstream ss.
No functional change.