Improve NonPawnCorrectionHistory indexing #5816
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bench 1632964 Co-authored-by: Andrew Grant <andrew.github@grantnet.us>
|
clang-format 18 needs to be run on this PR. (execution 12900826317 / attempt 1) |
xu-shawn
added a commit
to xu-shawn/Stockfish
that referenced
this pull request
Feb 2, 2025
Improves indexing scheme, by noting that both sides are likely to access the same non_pawn_index nearby. LLR: 2.93 (-2.94,2.94) <0.00,2.00> Total: 75936 W: 19905 L: 19554 D: 36477 Ptnml(0-2): 190, 7863, 21554, 8128, 233 https://tests.stockfishchess.org/tests/view/67904d0cfc8c306ba6cea332 closes official-stockfish#5816 No functional change Co-authored-by: Andrew Grant <andrew.github@grantnet.us>
Disservin
pushed a commit
to Disservin/Stockfish
that referenced
this pull request
Mar 21, 2025
https://tests.stockfishchess.org/tests/view/67da5b158c7f315cc372a9d2 LLR: 2.95 (-2.94,2.94) <0.00,2.00> Total: 150368 W: 38874 L: 38401 D: 73093 Ptnml(0-2): 424, 16821, 40262, 17212, 465 Make CorrectionHistory\<NonPawn\> handle both black and white internally. A follow up to official-stockfish#5816 closes official-stockfish#5934 No functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bench 1632964
LLR: 2.93 (-2.94,2.94) <0.00,2.00>
Total: 75936 W: 19905 L: 19554 D: 36477
Ptnml(0-2): 190, 7863, 21554, 8128, 233
https://tests.stockfishchess.org/tests/view/67904d0cfc8c306ba6cea332
Improves indexing scheme, by noting that both sides are likely to access the same non_pawn_index nearby.
Seemingly passes an SPRT, which is shocking. But its objectively good practice.
Thanks to @xu-shawn for coding it up, after I mentioned it.