Skip to content

Conversation

@VoyagerOne
Copy link
Contributor

For enpassants the piece_on(to_sq) will be NONE.
So it will always skip the early return and run the very expensive see() call.
This tweak will make sure enpassants return early, which should prove to be a small speed up.

For enpassants the piece_on(to_sq) will be NONE.
So it will always skip the early return and run the very expensive see() call.
This tweak will make sure enpassants return early, which should prove to be a small speed up.
@mcostalba
Copy link
Contributor

Have you verified is a non functional change (it is not written in the
commit logs)

Have you done some speed tests?

On Fri, Jan 8, 2016 at 12:56 AM, VoyagerOne notifications@github.com
wrote:

For enpassants the piece_on(to_sq) will be NONE.
So it will always skip the early return and run the very expensive see()
call.
This tweak will make sure enpassants return early, which should prove to

be a small speed up.

You can view, comment on, or merge this pull request online at:

#563
Commit Summary

  • SEE

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#563.

@KassiasGrandiel
Copy link

The bench of VoyagerOne's patch is 8603285 It's the same as master so there's most likely no functional change

@zamar
Copy link

zamar commented Jan 9, 2016

@VoyagerOne:

But on the other hand, en passant capture are very rare.

Personally I wouldn't expect any speed gains on this change. Please provide some benchmarks to support your patch.

@VoyagerOne
Copy link
Contributor Author

@zamar
I am not sure the best way to test for speed.
So you can just close this request if you like.

@mstembera
Copy link
Contributor

@zamar
Copy link

zamar commented Jan 9, 2016

@VoyagerOne:

It's up to you.

  • If you want to provide evidence for your patch, please do so.
  • If you don't feel like it, then just close the pull request...

@VoyagerOne
Copy link
Contributor Author

@zamar
Ok I will close it.

BTW, if you are around...I have a patch that needs approval.

@VoyagerOne VoyagerOne closed this Jan 9, 2016
@VoyagerOne VoyagerOne deleted the SEE branch January 25, 2016 16:23
MichaelB7 pushed a commit to MichaelB7/Stockfish that referenced this pull request Dec 14, 2019
MichaelB7 pushed a commit to MichaelB7/Stockfish that referenced this pull request Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants