Move Loop Consistency in Probcut #5463
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bench 1124658
vondele
reviewed
Jul 9, 2024
| { | ||
| assert(move.is_ok()); | ||
|
|
||
| if (move == excludedMove) |
Member
There was a problem hiding this comment.
join those two if statements, no need for comment
There was a problem hiding this comment.
if (move == excludedMove || !pos.legal(move))
continue;
Contributor
Author
There was a problem hiding this comment.
But in the other move loop, these two if statements are separated, and all the other legality checks have a comment on them, so I feel that this way is more consistent?
yl25946
added a commit
to yl25946/Stockfish
that referenced
this pull request
Jul 9, 2024
In probcut move loop, everything is enclosed within a large if statement. I've changed it to guard clauses to stay consistent with other move loops. closes official-stockfish#5463 No functional change
linrock
pushed a commit
to linrock/Stockfish
that referenced
this pull request
Jul 9, 2024
In probcut move loop, everything is enclosed within a large if statement. I've changed it to guard clauses to stay consistent with other move loops. closes official-stockfish#5463 No functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In probcut move loop, everything is enclosed within a large if statement. I've changed it to guard clauses to stay consistent with other move loops.