Skip to content

Conversation

@FauziAkram
Copy link
Contributor

@FauziAkram FauziAkram commented Mar 12, 2024

Parameters Tweak.
Including also @cj5716 double aging tweak in tt.cpp

Passed STC:
LLR: 2.94 (-2.94,2.94) <0.00,2.00>
Total: 24480 W: 6459 L: 6153 D: 11868
Ptnml(0-2): 101, 2798, 6184, 3008, 149
https://tests.stockfishchess.org/tests/view/65ef15220ec64f0526c44b04

Passed LTC:
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 53316 W: 13561 L: 13203 D: 26552
Ptnml(0-2): 27, 5925, 14408, 6259, 39
https://tests.stockfishchess.org/tests/view/65ef4bac0ec64f0526c44f50

Bench: 1715522

@mstembera
Copy link
Contributor

Why are we including the TT aging tweak? It didn't even finish yellow. https://tests.stockfishchess.org/tests/view/65ee7ef10ec64f0526c440dd

@FauziAkram
Copy link
Contributor Author

@mstembera
Copy link
Contributor

@FauziAkram Ah thanks! I looked at the wrong test and didn't see the earlier ones.

@Lowform
Copy link

Lowform commented Mar 12, 2024

Simplification of TT tweak could be tested as it removes *2. Even if search+movepick tuning was done with included TT tweak, good practice after passing gaining tests would be to next try simplifying added logic (in this case multiplication with new parameter *2). This way we know for sure if added logic (however simple it may be) is elo gaining.

@FauziAkram
Copy link
Contributor Author

FauziAkram commented Mar 12, 2024

@Lowform From my point of view, its better to leave it as it is for some time, and maybe we can try to simplify it after some time has passed.

@Disservin
Copy link
Member

@FauziAkram I have also said this on discord, but I am not at all sure why you included this in your patch. You asked me if it is fine if you include it in a tune, so I assumed you meant a spsa tune which tunes this. Not randomly adding it on top of another patch, these things should be avoided. One should always thrive to first test something isolated and then make it more complex. If you have a large tune with many tuned variables it doesn’t make much sense to test them individually because it takes a) too long b) they might not synergize well… but this is just randomly adding patches together ?

@FauziAkram
Copy link
Contributor Author

I didn't randomly add patches together.
All tune patches, change more than a single parameter, this patch is the same.
Only parameter changes.

linrock pushed a commit to linrock/Stockfish that referenced this pull request Mar 27, 2024
Passed STC:
https://tests.stockfishchess.org/tests/view/65ef15220ec64f0526c44b04
LLR: 2.94 (-2.94,2.94) <0.00,2.00>
Total: 24480 W: 6459 L: 6153 D: 11868
Ptnml(0-2): 101, 2798, 6184, 3008, 149

Passed LTC:
https://tests.stockfishchess.org/tests/view/65ef4bac0ec64f0526c44f50
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 53316 W: 13561 L: 13203 D: 26552
Ptnml(0-2): 27, 5925, 14408, 6259, 39

closes official-stockfish#5104

Bench: 1715522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants