Skip to content

Conversation

@cj5716
Copy link
Contributor

@cj5716 cj5716 commented Dec 1, 2023

Simplify an old commit github.com/official-stockfish/Stockfish/commit/72760c05c64d1fb2bb71c2ac54acfbeecf513b87.

Search is not stuck on the test position given r1n1n1b1/1P1P1P1P/1N1N1N2/2RnQrRq/2pKp3/3BNQbQ/k7/4Bq2 w - - 0 1

Passed STC
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 236160 W: 59475 L: 59475 D: 117210
Ptnml(0-2): 841, 28266, 59816, 28366, 791
https://tests.stockfishchess.org/tests/view/6567050d136acbc573550919

Passed LTC
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 201690 W: 49630 L: 49593 D: 102467
Ptnml(0-2): 128, 23214, 54122, 23255, 126
https://tests.stockfishchess.org/tests/view/6567d133136acbc573551c78

Bench: 1199035

@Disservin
Copy link
Member

Disservin commented Dec 1, 2023

@cj5716 i think the tests failed because you are missing a : in the bench

@peregrineshahin
Copy link
Contributor

@cj5716 i think the tests failed because you are missing a : in the bench

That's optional, The test is falling on all the other 4 PRs, the check-includes are failing.

@Disservin
Copy link
Member

Disservin commented Dec 1, 2023

@peregrineshahin no, on this the Stockfisch tests are failing as well.

@peregrineshahin
Copy link
Contributor

the : is optional here

          for hash in $(git rev-list -100 HEAD); do
            benchref=$(git show -s $hash | tac | grep -m 1 -o -x '[[:space:]]*\b[Bb]ench[ :]\+[1-9][0-9]\{5,7\}\b[[:space:]]*' | sed 's/[^0-9]//g') && break || true
          done

@Disservin
Copy link
Member

I see but still the CI extracted a wrong bench related to this pr https://github.com/official-stockfish/Stockfish/actions/runs/7054420272/job/19203254803. This should be unrelated to the analyzer failing issue

@peregrineshahin
Copy link
Contributor

It's failing because it's not written on a separate line in the commit message.
Do you think such a thing should be a requirement?
I don't think is is how it's done in fishtest even in my PR https://github.com/official-stockfish/fishtest/pull/1840/files

@peregrineshahin
Copy link
Contributor

my_string="somemessage   Bench: 98765432"
result=$(echo "$my_string" | tac | grep -m 1 -o -x '[[:space:]]*\b[Bb]ench[ :]\+[1-9][0-9]\{5,7\}\b[[:space:]]*' | sed 's/[^0-9]//g')
echo "Extracted benchmark value: $result"

this does not match....

@Disservin
Copy link
Member

Ah I see thanks. I think a separate line is fine but should probably be documented somewhere if that’s not the case already.

@peregrineshahin
Copy link
Contributor

Ah I see thanks. I think a separate line is fine but should probably be documented somewhere if that’s not the case already.

Well we accept non-separate lines in fishtest, many devs use this when testing because they don't worry about adding a description.
Sometimes like "Take 1 bench: 9999999" in one line.

However, in PR'ing here it looks inconsistent that Stockfish CI does not accept it..

Simplify an old commit github.com/official-stockfish/Stockfish/commit/72760c05c64d1fb2bb71c2ac54acfbeecf513b87.

Search is not stuck on the test position given r1n1n1b1/1P1P1P1P/1N1N1N2/2RnQrRq/2pKp3/3BNQbQ/k7/4Bq2 w - - 0 1

Passed STC
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 236160 W: 59475 L: 59475 D: 117210
Ptnml(0-2): 841, 28266, 59816, 28366, 791
https://tests.stockfishchess.org/tests/view/6567050d136acbc573550919

Passed LTC
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 201690 W: 49630 L: 49593 D: 102467
Ptnml(0-2): 128, 23214, 54122, 23255, 126
https://tests.stockfishchess.org/tests/view/6567d133136acbc573551c78

Bench: 1199035
@Disservin Disservin added the to be merged Will be merged shortly label Dec 2, 2023
@Disservin Disservin closed this in 15d47a2 Dec 2, 2023
windfishballad pushed a commit to windfishballad/Stockfish that referenced this pull request Jan 23, 2024
Simplify an old commit
official-stockfish@72760c0.

Search is not stuck on the test position given
r1n1n1b1/1P1P1P1P/1N1N1N2/2RnQrRq/2pKp3/3BNQbQ/k7/4Bq2 w - - 0 1

Passed STC:
https://tests.stockfishchess.org/tests/view/6567050d136acbc573550919
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 236160 W: 59475 L: 59475 D: 117210
Ptnml(0-2): 841, 28266, 59816, 28366, 791

Passed LTC:
https://tests.stockfishchess.org/tests/view/6567d133136acbc573551c78
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 201690 W: 49630 L: 49593 D: 102467
Ptnml(0-2): 128, 23214, 54122, 23255, 126

closes official-stockfish#4896

Bench: 1604361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

to be merged Will be merged shortly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants