-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Remove recaptures stage in qsearch #4896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cj5716 i think the tests failed because you are missing a : in the bench |
That's optional, The test is falling on all the other 4 PRs, the check-includes are failing. |
|
@peregrineshahin no, on this the Stockfisch tests are failing as well. |
|
the |
|
I see but still the CI extracted a wrong bench related to this pr https://github.com/official-stockfish/Stockfish/actions/runs/7054420272/job/19203254803. This should be unrelated to the analyzer failing issue |
|
It's failing because it's not written on a separate line in the commit message. |
this does not match.... |
|
Ah I see thanks. I think a separate line is fine but should probably be documented somewhere if that’s not the case already. |
Well we accept non-separate lines in fishtest, many devs use this when testing because they don't worry about adding a description. However, in PR'ing here it looks inconsistent that Stockfish CI does not accept it.. |
4c68c32 to
1d0de36
Compare
Simplify an old commit github.com/official-stockfish/Stockfish/commit/72760c05c64d1fb2bb71c2ac54acfbeecf513b87. Search is not stuck on the test position given r1n1n1b1/1P1P1P1P/1N1N1N2/2RnQrRq/2pKp3/3BNQbQ/k7/4Bq2 w - - 0 1 Passed STC LLR: 2.93 (-2.94,2.94) <-1.75,0.25> Total: 236160 W: 59475 L: 59475 D: 117210 Ptnml(0-2): 841, 28266, 59816, 28366, 791 https://tests.stockfishchess.org/tests/view/6567050d136acbc573550919 Passed LTC LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 201690 W: 49630 L: 49593 D: 102467 Ptnml(0-2): 128, 23214, 54122, 23255, 126 https://tests.stockfishchess.org/tests/view/6567d133136acbc573551c78 Bench: 1199035
1d0de36 to
24027e3
Compare
Simplify an old commit official-stockfish@72760c0. Search is not stuck on the test position given r1n1n1b1/1P1P1P1P/1N1N1N2/2RnQrRq/2pKp3/3BNQbQ/k7/4Bq2 w - - 0 1 Passed STC: https://tests.stockfishchess.org/tests/view/6567050d136acbc573550919 LLR: 2.93 (-2.94,2.94) <-1.75,0.25> Total: 236160 W: 59475 L: 59475 D: 117210 Ptnml(0-2): 841, 28266, 59816, 28366, 791 Passed LTC: https://tests.stockfishchess.org/tests/view/6567d133136acbc573551c78 LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 201690 W: 49630 L: 49593 D: 102467 Ptnml(0-2): 128, 23214, 54122, 23255, 126 closes official-stockfish#4896 Bench: 1604361
Simplify an old commit github.com/official-stockfish/Stockfish/commit/72760c05c64d1fb2bb71c2ac54acfbeecf513b87.
Search is not stuck on the test position given r1n1n1b1/1P1P1P1P/1N1N1N2/2RnQrRq/2pKp3/3BNQbQ/k7/4Bq2 w - - 0 1
Passed STC
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 236160 W: 59475 L: 59475 D: 117210
Ptnml(0-2): 841, 28266, 59816, 28366, 791
https://tests.stockfishchess.org/tests/view/6567050d136acbc573550919
Passed LTC
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 201690 W: 49630 L: 49593 D: 102467
Ptnml(0-2): 128, 23214, 54122, 23255, 126
https://tests.stockfishchess.org/tests/view/6567d133136acbc573551c78
Bench: 1199035