Cleanup code after dropping ICC support in favor of ICX #4769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit removes all uses of ICC's __INTEL_COMPILER macro and other references to ICC. It also adds ICX info to the compiler command and fixes two typos in Makefile's help output. No functional change
Contributor
Author
|
@maximmasiutin I would appreciate if you can perform a quick test with ICX. |
Contributor
|
I no longer have a machine where I tested the ICX, cannot test now :-( |
Member
|
works for me (after downloading and installing icx from https://www.intel.com/content/www/us/en/developer/tools/oneapi/toolkits.html#base-kit) |
Contributor
|
Thank you! |
Member
|
I am fine with the patch. If I remember correctly, ICC support was added by Marco back in the days but obviously not tested for years. The only complain we might have with the patch is with somebody with a vintage machine unable to install gcc, but that’s very unlikely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit removes all uses of ICC's __INTEL_COMPILER macro and other references to ICC. It also adds ICX info to the compiler command and fixes two typos in Makefile's help output.
No functional change