nnue namespace cleanup #4445
Closed
nnue namespace cleanup #4445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I would keep init and verify in the NNUE namespace because being directly under Eval makes them seem like they are part of classical eval. |
Joachim26
pushed a commit
to Joachim26/StockfishNPS
that referenced
this pull request
Mar 19, 2023
This patch moves the nnue namespace in the appropiate header that correspondes with the definition. It also makes navigation a bit easier. closes official-stockfish#4445 No functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the nnue namespace in the appropiate header that correspondes with the definition. It also makes navigation a bit easier imo.
I removed the
initandverifyfunctions from the nnue namespace since I think they dont quite belong there.Im happy to hear other people's comment on this.