Do not try to use large pages on 32 bit Windows. #3380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change.
|
@noobpwnftw Perhaps you want to mark this PR as potentially fixing #3379? (I'm honestly not sure, but it makes logical sense in my brain as something to do) |
Contributor
Author
|
@QuackQuackBlah I'm waiting on confirmation from that user yes. Added into commit message. |
Contributor
|
I can confirm that this patch allows the resulting binary to run under windows XP. |
Member
|
April 8, 2014 (we all remember). |
joergoster
pushed a commit
to joergoster/Stockfish-old
that referenced
this pull request
Mar 8, 2021
verified to work on windows XP. fixes #3379 closes official-stockfish/Stockfish#3380 No functional change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We override API availability when including headers for Windows APIs.
This patch disables the functions related to large pages on all 32-bit Windows targets because on those platforms, using large pages requires a different mechanism(AWE) and the API we currently use is not available under XP.
Fixes #3379.
No functional change.