[WIP] More aligned_alloc changes to support android #2973
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posix_memalign seems to be working for the android target, and should work for the others too. see official-stockfish#2860 test if this passes CI No functional change
vondele
added a commit
to vondele/Stockfish
that referenced
this pull request
Aug 11, 2020
Move to posix_memalign for those platforms, in particular android, that do not fully support c++17 std::aligned_alloc() (and are not windows) see official-stockfish#2860 closes official-stockfish#2973 No functional change
joergoster
pushed a commit
to joergoster/Stockfish-old
that referenced
this pull request
Aug 11, 2020
Move to posix_memalign for those platforms, in particular android, that do not fully support c++17 std::aligned_alloc() (and are not windows) see official-stockfish/Stockfish#2860 closes official-stockfish/Stockfish#2973 No functional change
lucabrivio
pushed a commit
to lucabrivio/Stockfish
that referenced
this pull request
Aug 11, 2020
Move to posix_memalign for those platforms, in particular android, that do not fully support c++17 std::aligned_alloc() (and are not windows) see official-stockfish/Stockfish#2860 closes official-stockfish/Stockfish#2973 No functional change
noobpwnftw
pushed a commit
to noobpwnftw/Stockfish
that referenced
this pull request
Aug 15, 2020
Move to posix_memalign for those platforms, in particular android, that do not fully support c++17 std::aligned_alloc() (and are not windows) see official-stockfish#2860 closes official-stockfish#2973 No functional change
Dantist
pushed a commit
to Dantist/Stockfish
that referenced
this pull request
Dec 22, 2020
Move to posix_memalign for those platforms, in particular android, that do not fully support c++17 std::aligned_alloc() (and are not windows) see official-stockfish#2860 closes official-stockfish#2973 No functional change
mizar
added a commit
to mizar/YaneuraOu
that referenced
this pull request
Sep 24, 2021
- misc.cpp : Android向けに不足していた定義の追加 see yaneurao@fa10bc3 see official-stockfish/Stockfish#2860 see official-stockfish/Stockfish#2973 see official-stockfish/Stockfish@399cddf - misc.cpp : aligned_large_pages_alloc() の引数の数をWIN32とそれ以外で合わせる
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
posix_memalign seems to be working for the android target, and should work for the others too.
see #2860
test if this passes CI
No functional change