Skip to content

Conversation

@gvreuls
Copy link
Contributor

@gvreuls gvreuls commented Aug 7, 2020

This is a partial PR concerning NNUE CI and PGO builds requested by
@vondele, it modifies the appveyor script so it downloads the default
NNUE net before the stockfish bench is run.

If have avoided using aliases like cat and echo because I don't know if
these are defined in the appveyor environment.

Note: I can't guarantee 100% that this works because to my knowledge
there is no way of testing the script before making the PR.

No functional change.

gvreuls added 3 commits August 7, 2020 17:07
This is a partial PR concerning NNUE CI and PGO builds requested by
@vondele, it modifies the appveyor script so it downloads the default
NNUE net before the stockfish bench is run.

If have avoided using aliases like cat and echo because I don't know if
these are defined in the appveyor environment.

Note: I can't guarantee 100% that this works because to my knowledge
there is no way of testing the script before merging it to master.

No functional change.
@vondele
Copy link
Member

vondele commented Aug 7, 2020

@gvreuls probably the net needs to be put in cd src/%CONFIGURATION% since that seems to be where the engine is put.

@gvreuls
Copy link
Contributor Author

gvreuls commented Aug 7, 2020

@vondele I cant get the %CONFIGURATION% stuff to work, appveyor refuses to replace it with Debug/Release in my script. This is something for the appveyor specialists.

@vondele
Copy link
Member

vondele commented Aug 7, 2020

could it be you have to create the directory pre-download time, it doesn't exist, presumably, till the build has started.

@gvreuls
Copy link
Contributor Author

gvreuls commented Aug 7, 2020

@vondele The problem seems to be that %CONFIGURATION% isn't a real powershell variable but something appvayor replaces on the fly in some places but not in others. I've wasted six commits trying to get it to work and I'm at the end of my wits here, we really need somebody who knows how you're supposed to do this in appveyor.

@vondele
Copy link
Member

vondele commented Aug 7, 2020

Seems you found it, great!

@gvreuls
Copy link
Contributor Author

gvreuls commented Aug 7, 2020

@vondele Never mind my last post, it's working now, %CONFIGURATION% is a windows environment variable that must be accessed as ${env:CONFIGURATION} in powershell.

@vondele
Copy link
Member

vondele commented Aug 8, 2020

I'll close this, will be part of #2931

@vondele vondele closed this Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants