-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Download the default NNUE net in AppVeyor #2928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a partial PR concerning NNUE CI and PGO builds requested by @vondele, it modifies the appveyor script so it downloads the default NNUE net before the stockfish bench is run. If have avoided using aliases like cat and echo because I don't know if these are defined in the appveyor environment. Note: I can't guarantee 100% that this works because to my knowledge there is no way of testing the script before merging it to master. No functional change.
|
@gvreuls probably the net needs to be put in |
I can't get the %CONFIGURATION% stuff to work, must be some crude replacement script.
|
@vondele I cant get the %CONFIGURATION% stuff to work, appveyor refuses to replace it with Debug/Release in my script. This is something for the appveyor specialists. |
|
could it be you have to create the directory pre-download time, it doesn't exist, presumably, till the build has started. |
|
@vondele The problem seems to be that %CONFIGURATION% isn't a real powershell variable but something appvayor replaces on the fly in some places but not in others. I've wasted six commits trying to get it to work and I'm at the end of my wits here, we really need somebody who knows how you're supposed to do this in appveyor. |
|
Seems you found it, great! |
|
@vondele Never mind my last post, it's working now, %CONFIGURATION% is a windows environment variable that must be accessed as ${env:CONFIGURATION} in powershell. |
|
I'll close this, will be part of #2931 |
This is a partial PR concerning NNUE CI and PGO builds requested by
@vondele, it modifies the appveyor script so it downloads the default
NNUE net before the stockfish bench is run.
If have avoided using aliases like cat and echo because I don't know if
these are defined in the appveyor environment.
Note: I can't guarantee 100% that this works because to my knowledge
there is no way of testing the script before making the PR.
No functional change.