Fishtest Tuning Framework #2654
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reopens #1563 for the same reasons:
Integrate the tuning branch in master
Tuning parameters is commonly performed in fishtest, based on an infrastructure present in a separate 'tune' branch. However, the current situation has the following disadvantages:
Merging the branch in master fixes these issues.
There is no performance overhead of including the tuning branch:
Passed STC:
LLR: 2.96 (-2.94,2.94) [-3.00,1.00]
Total: 109710 W: 21990 L: 22032 D: 65688
http://tests.stockfishchess.org/tests/view/5add9b8c0ebc5975a378488a
Binary size is nearly unchanged (<0.5% increase).
This commit is essentially unchanged from the existing code, with small edits:
The comment by @snicolet that this is specialized C++ code still holds (#1563 (comment)), but I don't think this should stop us from integrating in-tree. The code has proven its value over the years.
No functional change.