Skip to content

Conversation

@snicolet
Copy link
Member

Reduce the "bad bishop" penalty when the bishop is protected by
one of our pawns, as it may indicate that the bishop has found
a safe spot outside the pawn chain.

STC:
LLR: 2.94 (-2.94,2.94) {-0.50,1.50}
Total: 176942 W: 34142 L: 33696 D: 109104
Ptnml(0-2): 3129, 20422, 40919, 20876, 3125
http://tests.stockfishchess.org/tests/view/5e6f61aae42a5c3b3ca2e62d

LTC:
LLR: 2.95 (-2.94,2.94) {0.25,1.75}
Total: 42252 W: 5615 L: 5322 D: 31315
Ptnml(0-2): 308, 3881, 12500, 4084, 353
http://tests.stockfishchess.org/tests/view/5e701382e42a5c3b3ca2e661

Bench: 4963440

Reduce the "bad bishop" penalty when the bishop is protected by
one of our pawns, as it may indicate that the bishop has found
a safe spot outside the pawn chain.

STC:
LLR: 2.94 (-2.94,2.94) {-0.50,1.50}
Total: 176942 W: 34142 L: 33696 D: 109104
Ptnml(0-2): 3129, 20422, 40919, 20876, 3125
http://tests.stockfishchess.org/tests/view/5e6f61aae42a5c3b3ca2e62d

LTC:
LLR: 2.95 (-2.94,2.94) {0.25,1.75}
Total: 42252 W: 5615 L: 5322 D: 31315
Ptnml(0-2): 308, 3881, 12500, 4084, 353
http://tests.stockfishchess.org/tests/view/5e701382e42a5c3b3ca2e661

Bench: 4963440
@snicolet
Copy link
Member Author

@vondele Note that we can get the same bench by using the following code for line 316 in the pull request, I am not sure which is more readable:

pull request:

 (1 + popcount(blocked & CenterFiles) - bool(attackedBy[Us][PAWN] & s));

alternative version:

 (!(attackedBy[Us][PAWN] & s) + popcount(blocked & CenterFiles));

@Vizvezdenec
Copy link
Member

Vizvezdenec commented Mar 17, 2020

second one is simplier :)
No strange bitboard -> bool conversion and no unneeded 1 and no unneeded minus.
Readability is ~ the same but second is simply shorter.

@vondele vondele closed this in 07caca2 Mar 17, 2020
@vondele
Copy link
Member

vondele commented Mar 17, 2020

Thanks!

@mstembera
Copy link
Contributor

The bool in the committed version after ! is not necessary nor can I find similar syntax in other parts of SF. Should I add it to the small cleanups PR?

@Vizvezdenec
Copy link
Member

@mstembera #2584 already mentioned :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants