Dynamic complexity #2516
Dynamic complexity #2516
Conversation
|
Looks like you have the wrong bench now? |
… into DynamicComplexity
Ahhh, you need to rebase on the latest master. Ok. |
| - 100 ; | ||
|
|
||
| // Give more importance to non-material score | ||
| score = (score * 2 - materialScore) / 2; |
There was a problem hiding this comment.
@Rocky640 is the line above correct, just wanted to confirm as in the PR description it says,
Instead of computing the initiative bonus on the material score + dynamic score
compute it on (material score/2) + dynamic score
Also before refactoring, we had dynamicScore added explicitly to the score returned from initiative before being added and assigned to the existing score like so:
score += dynScore + initiative(dynScore * 2 + score);
Is that still being done?
Just wanted to make sure that the refactored changes are equivalent to the original code that passed.
Also the bench in the last commit, 4765486 is different from what is in the PR description, do we need to update the correct bench there? Please confirm.
Thank you.
There was a problem hiding this comment.
a) Bench after refactoring (but before rebasing) was same as the one tested on fishtest.
b) Bench after rebasing had been added to pr description.
Everything is fine.
|
Thanks! |
Adjust initiative score by psqt/2 instead of materialScore/2 which simplifies #2516 Passed STC http://tests.stockfishchess.org/tests/view/5e2e667dab2d69d58394fc73 LLR: 2.94 (-2.94,2.94) {-1.50,0.50} Total: 23198 W: 4506 L: 4353 D: 14339 Ptnml(0-2): 396, 2615, 5380, 2728, 418 Passed LTC http://tests.stockfishchess.org/tests/view/5e2ed75cab2d69d58394fcbf LLR: 2.94 (-2.94,2.94) {-1.50,0.50} Total: 8519 W: 1179 L: 1062 D: 6278 Ptnml(0-2): 50, 775, 2472, 843, 74 closes #2522 Bench: 4684459
Instead of computing the initiative bonus on the material score + dynamic score compute it on (material score/2) + dynamic score, Passed STC http://tests.stockfishchess.org/tests/view/5e2c4945ab2d69d58394fa8f LLR: 2.94 (-2.94,2.94) {-1.00,3.00} Total: 39387 W: 7594 L: 7386 D: 24407 Ptnml(0-2): 658, 4519, 9165, 4649, 697 Passed LTC http://tests.stockfishchess.org/tests/view/5e2c85ccab2d69d58394faa7 LLR: 2.95 (-2.94,2.94) {0.00,2.00} Total: 32588 W: 4206 L: 3986 D: 24396 Ptnml(0-2): 244, 2909, 9738, 3111, 253 closes official-stockfish/Stockfish#2516 Bench: 4765486
Instead of computing the initiative bonus on the material score + dynamic score compute it on (material score/2) + dynamic score, Passed STC http://tests.stockfishchess.org/tests/view/5e2c4945ab2d69d58394fa8f LLR: 2.94 (-2.94,2.94) {-1.00,3.00} Total: 39387 W: 7594 L: 7386 D: 24407 Ptnml(0-2): 658, 4519, 9165, 4649, 697 Passed LTC http://tests.stockfishchess.org/tests/view/5e2c85ccab2d69d58394faa7 LLR: 2.95 (-2.94,2.94) {0.00,2.00} Total: 32588 W: 4206 L: 3986 D: 24396 Ptnml(0-2): 244, 2909, 9738, 3111, 253 closes official-stockfish/Stockfish#2516 Bench: 4765486
13 participants
Instead of computing the initiative bonus on the material score + dynamic score
compute it on (material score/2) + dynamic score,
Passed STC
http://tests.stockfishchess.org/tests/view/5e2c4945ab2d69d58394fa8f
LLR: 2.94 (-2.94,2.94) {-1.00,3.00}
Total: 39387 W: 7594 L: 7386 D: 24407
Ptnml(0-2): 658, 4519, 9165, 4649, 697
Passed LTC
http://tests.stockfishchess.org/tests/view/5e2c85ccab2d69d58394faa7
LLR: 2.95 (-2.94,2.94) {0.00,2.00}
Total: 32588 W: 4206 L: 3986 D: 24396
Ptnml(0-2): 244, 2909, 9738, 3111, 253
bench: 4958282
bench rebased on master #2514: 4765486