Introduce separate counter-move tables for captures #2344
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adentong
reviewed
Oct 5, 2019
src/search.cpp
Outdated
Comment on lines
338
to
341
| { | ||
| (ss-i)->continuationHistory = &this->continuationHistory[0][NO_PIECE][0]; // Use as sentinel | ||
| (ss-i)->continuationHistory = &this->continuationHistory[1][NO_PIECE][0]; // Use as sentinel | ||
| { |
There was a problem hiding this comment.
Echoing @vondele's concern, is this intended? It seems like you're assigning (ss-i)->continuationHistory twice.
Contributor
Author
There was a problem hiding this comment.
Not intended...I will remove the redundancy
snicolet
changed the title
Member
|
Merged via 2e96c51, congrats! :-) |
Contributor
|
Awesome patch - congrats! |
MichaelB7
pushed a commit
to MichaelB7/Stockfish
that referenced
this pull request
Oct 8, 2019
Enhance counter-move history table by adding a capture/no-capture dimension, depending wether the previous move was a quiet move or a capture. This doubles the size of the table but provides more accurate move ordering. STC: LLR: 2.95 (-2.94,2.94) [0.50,4.50] Total: 79702 W: 17720 L: 17164 D: 44818 http://tests.stockfishchess.org/tests/view/5d97945e0ebc590c21aa724b LTC: LLR: 2.96 (-2.94,2.94) [0.00,3.50] Total: 29147 W: 4907 L: 4651 D: 19589 http://tests.stockfishchess.org/tests/view/5d97ccb90ebc590c21aa7bc0 Closes official-stockfish#2344 Bench: 4131643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance CMH table by adding a capture Boolean dimension.
This will double the CMH table but provide more accurate move stats
STC:
LLR: 2.95 (-2.94,2.94) [0.50,4.50]
Total: 79702 W: 17720 L: 17164 D: 44818
http://tests.stockfishchess.org/tests/view/5d97945e0ebc590c21aa724b
LTC:
LLR: 2.96 (-2.94,2.94) [0.00,3.50]
Total: 29147 W: 4907 L: 4651 D: 19589
http://tests.stockfishchess.org/tests/view/5d97ccb90ebc590c21aa7bc0
Bench: 4131643