Do not define increment operators on Value, Depth and Direction #2160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These operators are never used and do not make sense for these types. No functional change.
|
I guess this makes sense. When I remove this line, my gcc5.4 makes exactly the same executable. shrugs shoulders |
Author
|
Yes this line has no effect. It adds a bunch of inline definitions that are never used (and should not be used IMO). It was somewhat confusing to me because other "full operators" are scale-invariant and the increment stands out. (E.g. it is natural to multiply Depth by 2, but the increment is ONE_PLY rather than 1). This is mainly cosmetic of course.
|
Member
|
Merged via 8b4521d, thanks! |
MichaelB7
added a commit
to MichaelB7/Stockfish
that referenced
this pull request
Jun 27, 2019
MichaelB7
added a commit
to MichaelB7/Stockfish
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These operators are never used and do not make sense for these types.
No functional change.