Make kingRing always 8 squares #1512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make kingRing always eight squares, extending the bitboard to the F file if the king is on the H file, and to the C file if the king is on the A file. This may deal with cases where Stockfish (like many other engines) would shift the king around on the back rank like g1h1, not because there is some imminent threat, but because it makes king safety look a little better just because the king ring had a smaller area. STC: LLR: 2.96 (-2.94,2.94) [0.00,5.00] Total: 34000 W: 7167 L: 6877 D: 19956 http://tests.stockfishchess.org/tests/view/5ab8216d0ebc5902932cbe64 LTC: LLR: 2.96 (-2.94,2.94) [0.00,5.00] Total: 22574 W: 3576 L: 3370 D: 15628 http://tests.stockfishchess.org/tests/view/5ab84e6a0ebc5902932cbe72 How to continue from there? This patch probably makes it easier to tune the king safety evaluation, because the new regularity of the king ring size will make the king safety function more continuous. Closes official-stockfish/Stockfish#1512 Bench: 5934103
Contributor
|
Nice idea! It removes some subtle bias in king evaluation. |
joergoster
pushed a commit
to joergoster/Stockfish-old
that referenced
this pull request
Mar 26, 2018
Make kingRing always eight squares, extending the bitboard to the F file if the king is on the H file, and to the C file if the king is on the A file. This may deal with cases where Stockfish (like many other engines) would shift the king around on the back rank like g1h1, not because there is some imminent threat, but because it makes king safety look a little better just because the king ring had a smaller area. STC: LLR: 2.96 (-2.94,2.94) [0.00,5.00] Total: 34000 W: 7167 L: 6877 D: 19956 http://tests.stockfishchess.org/tests/view/5ab8216d0ebc5902932cbe64 LTC: LLR: 2.96 (-2.94,2.94) [0.00,5.00] Total: 22574 W: 3576 L: 3370 D: 15628 http://tests.stockfishchess.org/tests/view/5ab84e6a0ebc5902932cbe72 How to continue from there? This patch probably makes it easier to tune the king safety evaluation, because the new regularity of the king ring size will make the king safety function more continuous. Closes official-stockfish/Stockfish#1512 Bench: 5934103
This was referenced Mar 26, 2018
|
This ide from Senpai 2.0.. |
goodkov
pushed a commit
to goodkov/Stockfish
that referenced
this pull request
Jul 21, 2018
Make kingRing always eight squares, extending the bitboard to the F file if the king is on the H file, and to the C file if the king is on the A file. This may deal with cases where Stockfish (like many other engines) would shift the king around on the back rank like g1h1, not because there is some imminent threat, but because it makes king safety look a little better just because the king ring had a smaller area. STC: LLR: 2.96 (-2.94,2.94) [0.00,5.00] Total: 34000 W: 7167 L: 6877 D: 19956 http://tests.stockfishchess.org/tests/view/5ab8216d0ebc5902932cbe64 LTC: LLR: 2.96 (-2.94,2.94) [0.00,5.00] Total: 22574 W: 3576 L: 3370 D: 15628 http://tests.stockfishchess.org/tests/view/5ab84e6a0ebc5902932cbe72 How to continue from there? This patch probably makes it easier to tune the king safety evaluation, because the new regularity of the king ring size will make the king safety function more continuous. Closes official-stockfish#1512 Bench: 5934103
Zerbinati
pushed a commit
to Zerbinati/Stockfish
that referenced
this pull request
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make kingRing always eight squares, extending the bitboard to the
F file if the king is on the H file, and to the C file if the king
is on the A file. This may deal with cases where Stockfish (like
many other engines) would shift the king around on the back rank
like g1h1, not because there is some imminent threat, but because
it makes king safety look a little better just because the king ring
had a smaller area.
STC:
LLR: 2.96 (-2.94,2.94) [0.00,5.00]
Total: 34000 W: 7167 L: 6877 D: 19956
http://tests.stockfishchess.org/tests/view/5ab8216d0ebc5902932cbe64
LTC:
LLR: 2.96 (-2.94,2.94) [0.00,5.00]
Total: 22574 W: 3576 L: 3370 D: 15628
http://tests.stockfishchess.org/tests/view/5ab84e6a0ebc5902932cbe72
How to continue from there?
This patch probably makes it easier to tune the king safety evaluation,
because the new regularity of the king ring size will make the king
safety function more continuous.
Closes #1512
Bench: 5934103