Bitbase index() from ADD to OR. No functional change. #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
agree. or is more self-documenting than add. |
|
Approved. |
Contributor
|
Looks good. |
niklasf
pushed a commit
to niklasf/Stockfish
that referenced
this pull request
Nov 28, 2016
Fix detection of final positions in racing kings
Alayan-stk-2
added a commit
to Alayan-stk-2/Stockfish
that referenced
this pull request
Feb 27, 2020
…icial-stockfish#132) Inspired by Vizvezdenec's patch for Stockfish. ELO | 3.12 +- 2.45 (95%) SPRT | 12.0+0.12s Threads=1 Hash=8MB LLR | 3.01 (-2.94, 2.94) [0.00, 5.00] Games | N: 37600 W: 9351 L: 9013 D: 19236 http://chess.grantnet.us/viewTest/4725/ ELO | 2.38 +- 1.80 (95%) SPRT | 60.0+0.6s Threads=1 Hash=64MB LLR | 2.97 (-2.94, 2.94) [0.00, 5.00] Games | N: 56428 W: 11335 L: 10949 D: 34144 http://chess.grantnet.us/viewTest/4728/ BENCH : 6,225,718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially wrote this as a speed optimization but because Intel has done a great job making the ADD instruction with carry as fast as a bitwise OR it is exactly the same speed. I'm submitting it anyway because from a purist point of view the bitwise OR better reflects that the index is a series of bitfields as documented in the comment section instead of a number arrived at through an algebraic expression. Also it might still be faster on more primitive architectures. I realize this is very nit picky so if you don't like it just close the pull request. No functional change.