Retire asymmThreshold

mcostalba · mcostalba · commit f7742669cb52 · 2013-12-30T01:27:57.000+01:00
Verified with 40K games at long TC does not regress:
ELO: 1.74 +-1.9 (95%) LOS: 96.2%
Total: 39624 W: 6402 L: 6203 D: 27019

bench: 7762310
diff --git a/src/position.cpp b/src/position.cpp
@@ -1029,7 +1029,7 @@ int Position::see_sign(Move m) const {
   return see(m);
 }
 
-int Position::see(Move m, int asymmThreshold) const {
+int Position::see(Move m) const {
 
   Square from, to;
   Bitboard occupied, attackers, stmAttackers;
@@ -1096,15 +1096,6 @@ int Position::see(Move m, int asymmThreshold) const {
 
   } while (stmAttackers);
 
-  // If we are doing asymmetric SEE evaluation and the same side does the first
-  // and the last capture, it loses a tempo and gain must be at least worth
-  // 'asymmThreshold', otherwise we replace the score with a very low value,
-  // before negamaxing.
-  if (asymmThreshold)
-      for (int i = 0; i < slIndex; i += 2)
-          if (swapList[i] < asymmThreshold)
-              swapList[i] = - QueenValueMg * 16;
-
   // Having built the swap list, we negamax through it to find the best
   // achievable score from the point of view of the side to move.
   while (--slIndex)
diff --git a/src/position.h b/src/position.h
@@ -141,7 +141,7 @@ class Position {
   void undo_null_move();
 
   // Static exchange evaluation
-  int see(Move m, int asymmThreshold = 0) const;
+  int see(Move m) const;
   int see_sign(Move m) const;
 
   // Accessing hash keys
diff --git a/src/search.cpp b/src/search.cpp
@@ -1220,10 +1220,7 @@ namespace {
               continue;
           }
 
-          // Prune moves with negative or equal SEE and also moves with positive
-          // SEE where capturing piece loses a tempo and SEE < beta - futilityBase.
-          if (   futilityBase < beta
-              && pos.see(move, beta - futilityBase) <= 0)
+          if (futilityBase < beta && pos.see(move) <= 0)
           {
               bestValue = std::max(bestValue, futilityBase);
               continue;

Original file line number	Diff line number	Diff line change
`@@ -1220,10 +1220,7 @@ namespace {`
`1220`	`1220`	`continue;`
`1221`	`1221`	`}`
`1222`	`1222`
`1223`		`- // Prune moves with negative or equal SEE and also moves with positive`
`1224`		`- // SEE where capturing piece loses a tempo and SEE < beta - futilityBase.`
`1225`		`- if ( futilityBase < beta`
`1226`		`- && pos.see(move, beta - futilityBase) <= 0)`
	`1223`	`+ if (futilityBase < beta && pos.see(move) <= 0)`
`1227`	`1224`	`{`
`1228`	`1225`	`bestValue = std::max(bestValue, futilityBase);`
`1229`	`1226`	`continue;`