Fix a silly unstoppable eval bug

mcostalba · mcostalba · commit d50b33cacd25 · 2013-09-16T23:59:37.000+02:00
The logic is broken for black side because we get more bonus
for pawn in 7th rank than for pawn in 2nd rank!

Spotted by Reuven Peleg

bench:3884409
diff --git a/src/evaluate.cpp b/src/evaluate.cpp
@@ -906,7 +906,7 @@ Value do_evaluate(const Position& pos, Value& margin) {
     if (!b || pos.non_pawn_material(~us))
         return SCORE_ZERO;
 
-    return Unstoppable * int(relative_rank(WHITE, frontmost_sq(us, b)));
+    return Unstoppable * int(relative_rank(us, frontmost_sq(us, b)));
   }
 
 

Original file line number	Diff line number	Diff line change
`@@ -906,7 +906,7 @@ Value do_evaluate(const Position& pos, Value& margin) {`
`906`	`906`	`if (!b \|\| pos.non_pawn_material(~us))`
`907`	`907`	`return SCORE_ZERO;`
`908`	`908`
`909`		`- return Unstoppable * int(relative_rank(WHITE, frontmost_sq(us, b)));`
	`909`	`+ return Unstoppable * int(relative_rank(us, frontmost_sq(us, b)));`
`910`	`910`	`}`
`911`	`911`
`912`	`912`