Refactor bestvalue adjustment in qsearch

FauziAkram · Disservin · commit bab1cc300cbf · 2023-12-30T11:05:19.000+01:00
closes #4935 No functional change
diff --git a/AUTHORS b/AUTHORS
@@ -72,7 +72,7 @@ Fabian Beuke (madnight)
 Fabian Fichter (ianfab)
 Fanael Linithien (Fanael)
 fanon
-Fauzi Akram Dabat (FauziAkram)
+Fauzi Akram Dabat (fauzi2)
 Felix Wittmann
 gamander
 Gabriele Lombardo (gabe)
diff --git a/src/search.cpp b/src/search.cpp
@@ -1616,8 +1616,8 @@ Value qsearch(Position& pos, Stack* ss, Value alpha, Value beta, Depth depth) {
         return mated_in(ss->ply);  // Plies to mate from the root
     }
 
-    if (std::abs(bestValue) < VALUE_TB_WIN_IN_MAX_PLY)
-        bestValue = bestValue >= beta ? (3 * bestValue + beta) / 4 : bestValue;
+    if (std::abs(bestValue) < VALUE_TB_WIN_IN_MAX_PLY && bestValue >= beta)
+        bestValue = (3 * bestValue + beta) / 4;
 
     // Save gathered info in transposition table
     tte->save(posKey, value_to_tt(bestValue, ss->ply), pvHit,

Original file line number	Diff line number	Diff line change
`@@ -1616,8 +1616,8 @@ Value qsearch(Position& pos, Stack* ss, Value alpha, Value beta, Depth depth) {`
`1616`	`1616`	`return mated_in(ss->ply); // Plies to mate from the root`
`1617`	`1617`	`}`
`1618`	`1618`
`1619`		`- if (std::abs(bestValue) < VALUE_TB_WIN_IN_MAX_PLY)`
`1620`		`- bestValue = bestValue >= beta ? (3 * bestValue + beta) / 4 : bestValue;`
	`1619`	`+ if (std::abs(bestValue) < VALUE_TB_WIN_IN_MAX_PLY && bestValue >= beta)`
	`1620`	`+ bestValue = (3 * bestValue + beta) / 4;`
`1621`	`1621`
`1622`	`1622`	`// Save gathered info in transposition table`
`1623`	`1623`	`tte->save(posKey, value_to_tt(bestValue, ss->ply), pvHit,`