Fix KBPK bug

leachjoinery · mcostalba · commit 5e331f9618a0 · 2013-08-24T10:08:03.000+02:00
With

position fen 7k/8/8/8/8/7P/6K1/7B w - - 0 1
go depth 25

The evaluation at depth 22 is not draw as it should be. The reason is that
when search reaches the position 8/6kP/8/8/8/3B4/6K1/8 w - - 0 1 if white plays
h8R or h8N then we get a position that is a "KNOWN_WIN" and is _not_ a check, so
futility pruning in qsearch kicks in and black may think that it is "futile"
to reply Kxh8 since, according to the logic of the code, it cannot raise the score
back towards a draw.

bench: 4728533
diff --git a/src/search.cpp b/src/search.cpp
@@ -1230,6 +1230,7 @@ namespace {
           && !givesCheck
           &&  move != ttMove
           &&  type_of(move) != PROMOTION
+          &&  futilityBase > -VALUE_KNOWN_WIN
           && !pos.is_passed_pawn_push(move))
       {
           futilityValue =  futilityBase

Original file line number	Diff line number	Diff line change
`@@ -1230,6 +1230,7 @@ namespace {`
`1230`	`1230`	`&& !givesCheck`
`1231`	`1231`	`&& move != ttMove`
`1232`	`1232`	`&& type_of(move) != PROMOTION`
	`1233`	`+ && futilityBase > -VALUE_KNOWN_WIN`
`1233`	`1234`	`&& !pos.is_passed_pawn_push(move))`
`1234`	`1235`	`{`
`1235`	`1236`	`futilityValue = futilityBase`