Revert "Cache line aligned TT"

mcostalba · mcostalba · commit 293c44bc0958 · 2013-04-30T19:42:21.000+02:00
This reverts commit 083fe58 It seems to break Android build No functional change.
diff --git a/src/misc.cpp b/src/misc.cpp
@@ -237,8 +237,10 @@ void prefetch(char* addr) {
 
 #  if defined(__INTEL_COMPILER) || defined(_MSC_VER)
   _mm_prefetch(addr, _MM_HINT_T0);
+  _mm_prefetch(addr+64, _MM_HINT_T0); // 64 bytes ahead
 #  else
   __builtin_prefetch(addr);
+  __builtin_prefetch(addr+64);
 #  endif
 }
 
diff --git a/src/tt.cpp b/src/tt.cpp
@@ -39,18 +39,18 @@ void TranspositionTable::set_size(size_t mbSize) {
   if (hashMask == size - ClusterSize)
       return;
 
-  free(mem);
-  mem = malloc(size * sizeof(TTEntry) + (CACHE_LINE_SIZE - 1));
-  if (!mem)
+  hashMask = size - ClusterSize;
+  delete [] table;
+  table = new (std::nothrow) TTEntry[size];
+
+  if (!table)
   {
       std::cerr << "Failed to allocate " << mbSize
                 << "MB for transposition table." << std::endl;
       exit(EXIT_FAILURE);
   }
 
-  table = (TTEntry*)((size_t(mem) + CACHE_LINE_SIZE - 1) & ~(CACHE_LINE_SIZE - 1));
-  hashMask = size - ClusterSize;
-  clear(); // Newly allocated block of memory is not initialized
+  clear(); // Operator new is not guaranteed to initialize memory to zero
 }
 
 
diff --git a/src/tt.h b/src/tt.h
@@ -85,7 +85,7 @@ class TranspositionTable {
   static const unsigned ClusterSize = 4; // A cluster is 64 Bytes
 
 public:
- ~TranspositionTable() { free(mem); }
+ ~TranspositionTable() { delete [] table; }
   void new_search() { generation++; }
 
   TTEntry* probe(const Key key) const;
@@ -98,7 +98,6 @@ class TranspositionTable {
 private:
   uint32_t hashMask;
   TTEntry* table;
-  void* mem;
   uint8_t generation; // Size must be not bigger then TTEntry::generation8
 };
 
diff --git a/src/types.h b/src/types.h
@@ -56,11 +56,10 @@
 #   include <xmmintrin.h> // Intel and Microsoft header for _mm_prefetch()
 #  endif
 
-#define CACHE_LINE_SIZE 64
 #if defined(_MSC_VER) || defined(__INTEL_COMPILER)
-#  define CACHE_LINE_ALIGNMENT __declspec(align(CACHE_LINE_SIZE))
+#  define CACHE_LINE_ALIGNMENT __declspec(align(64))
 #else
-#  define CACHE_LINE_ALIGNMENT  __attribute__ ((aligned(CACHE_LINE_SIZE)))
+#  define CACHE_LINE_ALIGNMENT  __attribute__ ((aligned(64)))
 #endif
 
 #if defined(_MSC_VER)

Original file line number	Diff line number	Diff line change
`@@ -237,8 +237,10 @@ void prefetch(char* addr) {`
`237`	`237`
`238`	`238`	`# if defined(__INTEL_COMPILER) \|\| defined(_MSC_VER)`
`239`	`239`	`_mm_prefetch(addr, _MM_HINT_T0);`
	`240`	`+ _mm_prefetch(addr+64, _MM_HINT_T0); // 64 bytes ahead`
`240`	`241`	`# else`
`241`	`242`	`__builtin_prefetch(addr);`
	`243`	`+ __builtin_prefetch(addr+64);`
`242`	`244`	`# endif`
`243`	`245`	`}`
`244`	`246`