Open
Conversation
(this typically happens on the crosshair mark which uses the same shared pointer transform on its submarks) closes #2052
|
Thanks @Fil! Would love to see this reviewed and released. We would make use of this immediately. |
|
Is there anything specific holding this back? |
Contributor
Author
lack of time. We'll get to it eventually. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Controlling this event is necessary because (internally) we only want to process it once, even when it's tied to several marks. This typically happens on the crosshair mark which uses the same shared pointer transform on its submarks, where not controlling this would result in an even number of flag toggling — when we just want one.
However for some applications the upstream app also wants to see that event.
In this PR, instead of preventing propagation, we ignore internal duplicate handling.
closes #2052
cc: @jheer
For more context see commit 8174cfa3 as part of PR #1527.