Draft
Conversation
Contributor
|
Sounds good. I'll work on a unit test. |
Contributor
|
I've added a unit test, however it reveals some other issues. I'll comment inline. |
Fil
reviewed
Sep 9, 2024
test/plots/bigint.ts
Outdated
| return Plot.plot({ | ||
| height: 500, | ||
| x: {percent: true, grid: true}, | ||
| y: {domain: [1.3, 2.21]}, |
Contributor
There was a problem hiding this comment.
If you remove the y.domain here, the chart works in preview but crashes in node tests. I don't understand what the difference might be.
Contributor
There was a problem hiding this comment.
This is how the chart looks like in preview. But it crashes in node. Is apache-arrow behaving differently in the browser?
Contributor
There was a problem hiding this comment.
OK the test is now fixed — I just don't use a file and generate the arrow structure on the fly.
this test output is broken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. #2155 (review)
Note that in the case of DuckDB-Wasm, we default
config.query.castBigIntToDoubleto true, so we shouldn’t see BigInt in practice with DuckDB, but we might still see it when loading Arrow or Parquet files.