refactor(spec)!: retire the external-lookup and message-queue config families (ADR-0049, #8075) - #8230
Merged
huangyiirene merged 5 commits intoAug 12, 2026
Conversation
…lies (ADR-0049, #8075) Fork (b) of the #8075 census: both modules are dead declarations whose only distinctive feature was an inline-credential sink. Route 3 retirement — no tombstone, no D2 conversion; RETIRED_DEFS_BY_MAJOR[17] (8 defs) + the D3 SemanticMigration external-lookup-message-queue-families-retired are the declaration. The #5552 data/ExternalFieldMapping:transform retired-keys entry is subsumed by the def retirement. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r
…ire-dead-credential-schemas
…824, PROTOCOL_MAP rows, strictness-ledger rows (#8075) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 106 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
⛔ 7 release-owned page(s) also reference the affected code. These are read-only:
|
github-actions
Bot
added
size/xl
documentation
…ire-dead-credential-schemas
…ding lap, #8075) Merge a296d81 took main's side of every os-regen path; this regeneration recomputes them from the merged sources — the 8 retired defs and 39 authorable keys leave again (deliberate deletions re-applied under the manifest gate), main's audit-log semantic entry, page.zod/editability references and the build-docs integration fix (#8219) all survive. check:generated 13/13. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r
Collaborator
Author
|
Landing lap (os-regen) complete —
PR stays draft; PM drives flip + auto-merge. Generated by Claude Code Generated by Claude Code |
huangyiirene
marked this pull request as ready for review
August 12, 2026 22:35
huangyiirene
deleted the
claude/issue-8075-retire-dead-credential-schemas
branch
August 12, 2026 22:52
huangyiirene
pushed a commit
that referenced
this pull request
Aug 12, 2026
…tree (#7872 relay lap over #8230/#8232) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r
huangyiirene
pushed a commit
that referenced
this pull request
Aug 13, 2026
os-regen merge lap for landing: merge origin/main (committed first, per scripts/pm/os-regen-merge.sh), then wholesale regen of the os-regen'd references/api pages from the merged tree. Sibling assertions on the regenerated tree: #8230 retirement state (def names only in retirement prose + migration entry), #8232 currency fraction-digit guard, #8234's 13 comparand-door exports in api-surface/data.json, #8236's groupBy union row all survive; MONGODB_MULTI_TENANT_UNSUPPORTED stays absent from the ledger and the references ErrorCode union reads main-minus-one (+265 -> +264; the union grew by 2 on main since the previous lap). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r
akarma-synetal
pushed a commit
to akarma-synetal/framework
that referenced
this pull request
Aug 17, 2026
… enforced once at the shared compile face for all five drivers (objectstack-ai#7872) (objectstack-ai#8234) * feat(spec): comparand-type door — accepted literal comparand set enforced at the shared compile face (objectstack-ai#7872) The measured superset string | number | bigint | boolean | null | Date is defined in packages/spec (filter-comparand-type.ts), enforced by parseFilterAST on everything it returns and by the engine's lowering seam on the object form; everything else is refused with the INVALID_FILTER / 400 envelope naming the accepted set. bigint is narrowed copy-on-write to its exact number (refused beyond 2^53), which kills the driver-memory mingo crash cell without touching the frozen driver; the mongo silent-edit cell ({qty: undefined} wiring to {} = match everything) becomes a refusal at the door. SQL-family allowlists source their set membership and wording from the door instead of local copies. FILTER_COMPARAND_TYPE_CASES conformance table added and consumed by all five driver suites. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r * chore(spec): regenerate api-surface + export-origins for the comparand-type door exports (objectstack-ai#7872) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r * test(objectql): re-judge the deep-equality operator-map pin under the objectstack-ai#7872 door Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r * chore(spec): regenerate api-surface + export-origins from the merged tree (objectstack-ai#7872 relay lap over objectstack-ai#8230/objectstack-ai#8232) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r * test(objectql): pay the two farm reds — registerObject arity, and un-erased engine option bags (objectstack-ai#7872) The door suite's registerObject(deal) call was missing the required packageId (the +1 over objectql's frozen TEST_DEBT 355); and its option bags used bare 'as any', which the query-options-erasure ratchet counts (240 -> 245). The bags now type-check uncast — FilterCondition's index signature admits the deliberately off-contract comparands, which is the point of the door — except the one FilterArray case, which carries the sanctioned 'as unknown as EngineQueryOptions' naming the contract it bypasses (not counted). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r --------- Co-authored-by: Claude <noreply@anthropic.com>
akarma-synetal
pushed a commit
to akarma-synetal/framework
that referenced
this pull request
Aug 17, 2026
…ger — a boot refusal never reaches a wire envelope (objectstack-ai#8035) (objectstack-ai#8239) * fix(spec): MONGODB_MULTI_TENANT_UNSUPPORTED leaves the error-code ledger (objectstack-ai#8035) The code was registered under @objectstack/driver-mongodb (objectstack-ai#3724) but no response envelope can carry it: the CLI boot handler rethrows the tenancy refusal pre-HTTP and aborts, and the one request-reachable trigger (assertObjectsNotTenantScoped via syncObjectSchema inside the metadata protocol's ensureObjectStorage) is swallowed by a documented best-effort catch. Registered-but-unemittable is the class the ledger header names; precedent OVERLAY_PERSISTENCE_FAILED / objectstack-ai#5783 — this instance is the sister shape (never had a wire path, rather than lost it), now documented in the header. The boot refusal stays untouched: MULTI_TENANT_UNSUPPORTED_CODE, the error class, its message, and the CLI's duck-typed literal match. A new driver-mongodb test pins the code literal (with the ledger row gone it is the only cross-package guard on the literal serve.ts matches); the ledger test now asserts the wire vocabulary refuses the retired string. Reference docs regenerated (ErrorCode enum 264 -> 263). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r * docs(spec): regenerate references from the merged tree (objectstack-ai#8035) os-regen merge lap for landing: merge origin/main (committed first, per scripts/pm/os-regen-merge.sh), then wholesale regen of the os-regen'd references/api pages from the merged tree. Sibling assertions on the regenerated tree: objectstack-ai#8230 retirement state (def names only in retirement prose + migration entry), objectstack-ai#8232 currency fraction-digit guard, objectstack-ai#8234's 13 comparand-door exports in api-surface/data.json, objectstack-ai#8236's groupBy union row all survive; MONGODB_MULTI_TENANT_UNSUPPORTED stays absent from the ledger and the references ErrorCode union reads main-minus-one (+265 -> +264; the union grew by 2 on main since the previous lap). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r --------- Co-authored-by: Claude <noreply@anthropic.com>
akarma-synetal
pushed a commit
to akarma-synetal/framework
that referenced
this pull request
Aug 17, 2026
…ered/virtualScroll (ADR-0049, objectstack-ai#7176) (objectstack-ai#8252) * refactor(spec)!: retire pass-through-only list-view keys striped/bordered/virtualScroll (ADR-0049, objectstack-ai#7176) Maintainer ruling 2026-08-10: every measured reader copies the key forward and ObjectGrid, where the chains end, never applies any of the three — copy-without-apply is dead in effect. retiredKey() tombstones on ListViewSchema (radiating into ObjectListViewSchema), ADR-0087 D2 conversion view-list-passthrough-keys-removed + D3 chain step + six RETIRED_KEYS_BY_MAJOR[17] entries, ledger rows flipped to dead with the retirement note, form inputs pruned, docs updated, changeset with FROM->TO. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r * test(spec): match the striped prescription's actual casing in the pin test Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r * merge origin/main (os-regen artifacts taken from main; regeneration follows) * chore(spec): regenerate artifacts after merging origin/main (4dc1c7d relay: objectstack-ai#8230/objectstack-ai#8232/objectstack-ai#8234/objectstack-ai#8236/objectstack-ai#8239) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123k4cam2jEAkPmbJeoaY3r --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8075
Phase 2 of the card: the ADR-0049 retirement route, following the ACCEPTed fork-(b) measurement (issue comment 5270144555, claim addendum 5270164082). Both dead credential-bearing schema families are removed whole —
data/external-lookup.zod.ts(3 defs: ExternalDataSource, ExternalFieldMapping, ExternalLookup — 8 exported names) andsystem/message-queue.zod.ts(5 defs: MessageQueueConfig, MessageQueueProvider, TopicConfig, ConsumerConfig, DeadLetterQueue — 14 exported names).Spot-verification of the measurement (on this branch's base, c10e9c3)
Re-ran the two load-bearing greps before deleting anything: zero files outside
packages/specreference either export-name family (all TS file types, excluding node_modules/dist/.cache), while the corpus-reach control (DatasourceSchemaunder identical exclusions) returns 8+ consumer files in the same run. Each module export was then verified individually: every non-test consumer of every export resolves inside the two modules themselves (ExternalLookupSchema was the only consumer of the other two data-side schemas, and is itself consumed by nothing; MessageQueueConfigSchema was the only consumer of its four siblings). The kernel "hits" for the MQ name are the substring insideEventMessageQueueConfigSchema— a different declaration, untouched. Liveness ledger: no rows exist for either module (absent, consistent with the modules never being metadata types) — nothing to delete, no orphan risk.Route and registration (per the spec-property-retirement playbook)
Route 3 — "nothing parses it": no carrier key, no door, no author document, so there is no tombstone and no D2 conversion (a prescription nobody can receive is noise; the #4834 / #4988 / #5055 / #6486 shape). The declaration is:
RETIRED_DEFS_BY_MAJOR[17]— 8 new entry files underpackages/spec/src/migrations/entries/retired-defs/(one per def, per the Splitmigrations/registry.ts's two append tables into per-entry files (registry half of #6957's ruling) #7297 conflict-free layout), concatenated bygen:migration-registry.SemanticMigrationexternal-lookup-message-queue-families-retired(entries/semantic/), carrying the three-axis reasoning, the replacement pointers (object.external+ datasource config for external data; kernelEventMessageQueueConfigfor MQ — no credential field by design), and acceptance criteria.Subsumed, the WidgetManifest.performance way: the #5552
data/ExternalFieldMapping:transformretired-keys entry (same unreleased major 17) — the def retirement is strictly stronger. Theshared/FieldMappingtombstone, theintegration/ConnectorFieldMappingspelling and thefield-mapping-transform-removedD2 conversion are untouched;shared/mapping.test.tsstill pins them.Ratchet-direction note (for review)
This is a whole-def deletion, so the instruments MUST move, and did: api-surface −22 names (pure removals, zero additions — verified by diff), authorable-surface −39 keys, json-schema.manifest −8 defs, export-origins −22, reference pages
data/external-lookup.mdxandsystem/message-queue.mdxdropped bygen:docs(228 files regenerated). Zero movement here would have meant the removal did not actually happen.Tests
data/external-lookup-retirement.test.ts,system/message-queue-retirement.test.ts): absence by resolved symbol identity over every public entry (zero holders for all 22 names), survivor pins for the live neighbours a too-wide sweep would take (ObjectExternalBindingSchema, ExternalCatalog trio, ImportFieldMappingSchema, EventMessageQueueConfig trio, DeadLetterQueueEntry trio, EventBusConfigSchema), file-deletion probes with anti-vacuity controls, runtime-namespace agreement, and two security-face pins:object.externalREJECTS an inlineauthenticationblock (strictObject,unrecognized_keys), and the liveEventMessageQueueConfigparses real configs while a smuggledsaslblock is stripped — nothing credential-shaped survives into the parsed value.Verification (all local, real output)
check:generated13/13 up to date (includes check:authorable-surface, check:api-surface, check:export-origins, check:docs, check:spec-changes, check:upgrade-guide, check:migration-registry, check:strictness-ledger, check:liveness).check:adr-0087-registrationPASS (changeset carries the registered marker),check:i18nPASS (9 packages in sync; no form inputs existed for either family),check:nul-bytesPASS,check:merge-driverPASS.pnpm --filter @objectstack/spec typecheckPASS; full spec suite on the MERGED tree: 385/385 files, 10150/10150 tests.turbo run build72/72 successful; examplesobjectstack validateon app-crm / app-showcase / app-todo all exit 0 (pre-existing warnings only); dogfood expression-conformance 3/3.packages/qa/dogfoodexpression-conformance ledger: zerocoversentries name either family (verified by count, not by pipe-masked grep); targeted suite run.Docs
gen:docs; index/meta regenerated.quick-reference.mdxloses the two rows (section counts decremented);build-docs.tspage lists drop the two names with deliberate-removal comments; the strictness ledger drops its twoexternal-lookup.zod.tsrows (the checker demands rows name existing files) with a retirement note;PROTOCOL_MAP.mddrops both module rows (its test refuses links to files that do not exist); the ADR-0122 pin file's count moves 826 to 824 with a receipt (Iso335/Iso586left with their retired schemas — ids retired, not freed).origin/mainwas merged twice under this branch (last at fa48973 — 3 spec files moved, all incontracts/, textually disjoint from this diff); the full §10 re-check (spec build, check:generated 13/13, full suite) ran on the merged tree.content/docs/releases/implementation-status.mdxstill calls external-lookup "pending" — releases-owned, filed as [docs] releases/implementation-status.mdx still lists external-lookup as a pending data protocol after the #8075 retirement #8165 (docs-only follow-up). The stalemessage-queuename in build-docs' INTEGRATION category is the DatabaseConnector.readReplicaConfig 是读副本的第二处死声明（ADR-0049 enforce-or-remove，#4468 收尾发现） #4480 connector-template ghost, not this surface — filed as Observation: build-docs.ts integration category lists 9 page names with no emitting module — onlyconnectorproduces a page #8166 (observation).Changeset
@objectstack/specmajor — acceptance surface shrinks on published exports (the #4583/#8078 precedent; the playbook's bump rule for removals). Carries the FROM → TO table, the one-line fix ("delete the import"), and the ADR-0087 markerregistered external-lookup-message-queue-families-retired.Landing note for the PM
os-regen faces ride this PR (authorable-surface, manifest, api-surface, export-origins, spec-changes, upgrade guide, references). The os-regen line was empty at dispatch; re-verify against current main at flip time — if main moved a spec face, this needs the regen-merge lap (
scripts/pm/os-regen-merge.sh), never a textual merge of the generated files.Generated by Claude Code