docs(adr): ADR-0135's two prose citations of the code name what the code now says - #18344
Merged
Merged
Conversation
…ode now says The mirror record describes, in the present tense, how this repository's code cites two cloud clauses. Both descriptions were true when the record was written and are false against the tree today: - D6 said the domain-verification clause is "the clause this repository's code cites as `ADR-0024 ②`". The live source cites `ADR-0135 D6` (auth-manager.ts 2793/3667/6654, auth-plugin.ts 2796, register-sso-provider.ts 316, auth-route-ledger.ts 238-239); `ADR-0024 ②` now survives only in CHANGELOGs. The bare form was also a bare cloud citation, which Prime Directive #13 forbids and which resolves against this registry to `0024-mcp-connectors.md` — a record whose sections are numbered 1-5 and that has no clause ②. - The #14361 consequence note quoted auth-manager.ts as citing `ADR-0024 V1`. That file reads `cloud ADR-0024 V1`, which is the spelling the same sentence goes on to prescribe. Every other unqualified `ADR-0024` under docs/adr is correct and is left alone: ten are the local MCP-connector record (verified against its own sections 3 and 4), and the rest are mentions of the bare string as a string, a line-wrapped `cloud ADR-0024`, and a literal grep pattern. Co-authored-by: Claude <noreply@anthropic.com>
github-actions
Bot
added
size/s
documentation
os-try-charles
added
the
skip-changeset
Claude
This was referenced Sep 16, 2026
os-try-charles
marked this pull request as ready for review
September 16, 2026 00:33
os-zhuang
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14361
Third and final segment. Segments 1 and 2 (PR #18228, last commit
0f95f4341) handled the 152 citations underpackages/**andcontent/docs. This segment is the remainder: every unqualifiedADR-0024underdocs/adr/.Clause-②: no
The instrument is wrong in both directions
The dispatch handed me a population of 21 bare lines in 7 files, measured as "lines matching
ADR-0024, minus lines containingcloud ADR-0024". I reproduced that 21 exactly. Then I re-measured per occurrence instead of per line:ADR-0024occurrences underdocs/adr/cloud ADR-0024cloud(backticks allowed)`objectstack-ai/cloud` ADR-0024and`cloud` ADR-0024. The literal-string filter does not see the qualifier. They are qualified and correct.`ADR-0024 V1`and also contains`cloud ADR-0024`later in the same line, sogrep -vdiscarded the whole line — hiding a bare citation. It is one of the two defects below.21 − 4 + 1 = 18. A third artifact is invisible to any line filter: ADR-0135 line 79 beginsADR-0024 chose the other direction, and its qualifiercloudis the last word of line 78. Line-wrapped, therefore qualified.Controls for every zero reported here are in the dev report.
Verdicts — 18 occurrences, each checked against the other end
The D-letter test that segments 1 and 2 used has zero resolving power here (0 of 18 carry a
Dclause letter), so every row is a read of the cited record.Local
docs/adr/0024-mcp-connectors.md— 10 sites, all correct0023-openapi-to-connector-generator.md:148./0024-mcp-connectors.md; title is MCP Servers as Connectors0024-mcp-connectors.md:10025-plugin-package-distribution.md:70025-plugin-package-distribution.md:3950025-plugin-package-distribution.md:5290036-app-as-rest-api-and-mcp-server.md:5@objectstack/connector-mcp, an adapter that connects to MCP servers — inbound0097-declarative-connector-instances.md:50097-declarative-connector-instances.md:199### 4.tier table, enterprise row, reads "sandboxed stdio execution"0097-declarative-connector-instances.md:205### 3."Credentials and config live with the MCP server… transportenv/headerscarry credentials"0101-mcp-stdio-principal-admission.md:5### 4.is the open/enterprise boundary carrying the trust assumptionThe two section citations are also structurally disambiguating: the local record numbers its sections
### 1.…### 5., while cloud ADR-0024 letters its clausesD1…D10/V1. A§4cannot be a cloud clause.docs/adr/0135-identity-and-access-architecture.md— 8 sites, 6 correct, 2 fixedADR-0024in this repository's code does NOT resolve to this record"0024-mcp-connectors.mdexists and is unrelated;0071here is Dataset semantic-layer depth as the same sentence claimscloudinverts itgit grep -n -E "ADR-0024" -- packages/…ADR-0024 chose the other directioncloudis the last word of line 78ADR-0024 ②"ADR-0135 D6—auth-manager.ts2793/3667/6654,auth-plugin.ts2796,register-sso-provider.ts316,auth-route-ledger.ts238–239.ADR-0024 ②survives only in CHANGELOGsADR-0024citation in this tree is not mechanically re-pointable"auth-manager.tscitesADR-0024 V1"auth-manager.ts:3661readscloud ADR-0024 V1ADR-0024citation should move"ADR-0024citation out ofplugin-auth"The two fixes
Both are present-tense descriptions of what this repository's code says. Both were true when the record was written and were made false by segments 1 and 2 of this same card.
Line 196. Under either reading the line was wrong. Read as a quotation of the code, it quotes a string the live source no longer contains. Read as naming the cloud clause, it is a bare cloud citation, which Prime Directive #13 forbids and which resolves against this registry to
0024-mcp-connectors.md— a record numbered 1–5 with no clause ②. The fix names the cloud clause and the spelling the code now uses, so both readings land.Line 248. A one-token insert. The same sentence already prescribes "those keep the
cloud ADR-0024spelling";auth-manager.tsnow does, and the quotation did not.Everything else is untouched. No citation that was already correct was moved.
Left alone, deliberately
ADR-0135's Consequences bullet (line 265 ff.) reads "Until then the citation still resolves to
docs/adr/0024-mcp-connectors.md". Its antecedent has now passed: the verbatim grep on line 63 returns 0 unqualified citations inplugin-auth/srcandplatform-objects/src/identity. The citation on that line is a correct mention, so it is not a defect of the kind this card is about; the surrounding tense is merely spent, and rewriting a mirror record's Consequences prose is a maintainer's call, not a per-site citation call. Flagged rather than edited — say the word and it moves in this PR.维护者速读(草稿)
改了什么 ——
docs/adr/0135-identity-and-access-architecture.md两处散文里对「本仓代码怎么引用」的描述,改成代码现在真正写的样子。共 7 增 6 删,只动这一个文件。为什么改 —— 这两句话在写下时是真的,是 #14361 前两段自己把它们变假的。196 行说域名验证子句「本仓代码引作
ADR-0024 ②」,而活代码七处已经引ADR-0135 D6,ADR-0024 ②只剩在 CHANGELOG 里;它同时还是一个裸的 cloud 引用,按 Prime Directive #13 会解析到本仓的0024-mcp-connectors.md,而那份记录分节是 1–5,根本没有子句 ②。248 行把auth-manager.ts引述成ADR-0024 V1,文件里写的是cloud ADR-0024 V1—— 恰是同一句话下半段要求保留的拼写。风险与代价(含回滚) —— 纯散文,零代码、零发布物。
docs/adr/**不在任何包的files[]里(70 个声明了files[]的包全部为 0 命中),所以无 changeset。回滚 = revert 这一个 commit,没有任何下游。唯一的判断风险是 196 行的改写:它比 248 行多改了几个字,如果您认为镜像记录应当只记 cloud 的字母而不提本仓代码今天的拼写,把它退回成`cloud ADR-0024` 的子句 ②即可,一行的事。席位意见 ——
你要做的 —— 这是治理面,需要您手工批准并合并;席位不入队、不武装 auto-merge。请特别看一眼「Left alone, deliberately」那一节:ADR-0135 Consequences 里的 "Until then" 已经过期,我没有动它,因为改镜像记录的 Consequences 散文不该由 dev 自己决定。您说改我就在本 PR 里改。
Acceptance notes
docs/adr/**is a governed surface. Draft, maintainer-merged. Not queued, auto-merge not armed.files[]; 0 of them ship anydocs/adrpath, anddocs/contains nopackage.json, sodocs/adr/**is not inside a workspace package at all. Fire control on the same scan: all 70 ship adistentry. Nothing published moves.noted, not filed:the "Until then" tense in ADR-0135's Consequences, above. Carrier named: this PR's reviewer.noted, not filed:the line-basedgrep -v 'cloud ADR-0024'recipe is quoted inside ADR-0135 line 63 itself and mis-bins 5 of 21 sites. It is correct as written there (that sentence counts citing lines at a past commit), so there is nothing to fix; but anyone reusing that recipe as a population filter will inherit the same 4 false positives and 1 false negative. Carrier: none — no open PR or queued card reuses it.Verification
All 19 gate families derived by
scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack(which takes the change set from the merge base itself) are green atc4d13026b.check:doc-formula-expressionsfirst exited 3 — PREREQUISITE NOT MET, which is not a finding; afterturbo run build --filter=@objectstack/formula --filter=@objectstack/lintit exits 0.pnpm lintis not owed and is not narrowed — it is not measured because the population is empty. eslint's own verdict on the only file in this diff isFile ignored because no matching configuration was supplied,eslint.config.mjscontains no markdown entry, and line 328 of that config records that noparserOptions.projectand no typed rules are enabled, so this diff cannot move any untouched file's verdict.🤖 Generated with Claude Code
https://claude.ai/code/session_017ef78bLdybu3AffehKkhfk
Generated by Claude Code