fix(lint): descend into conditional then/otherwise when building the _validations universe - #14820

Fixes #14700

What

validate-translation-references built its _validations universe with a flat walk of objects[].validations[]. A conditional rule's then / otherwise branch is itself a full rule carrying its own name, and that branch name — not the wrapper's — is the address checkConditional delegates to and authoredRuleMessage keys on at runtime (packages/objectql/src/validation/rule-validator.ts). The flat walk never saw a branch name, so a correct bundle entry for one was reported as an orphan translation-target-unknown, and the finding's own advice ("keeps its source locale in every refusal") was the opposite of the truth for that key — acting on it (deleting the entry) reintroduces the exact defect it fixed.

Fix

buildUniverse's walk over obj.validations now calls a small recursive collector (collectValidationRuleNames) instead of reading rule.name directly:

function collectValidationRuleNames(rule: AnyRec, validations: Set<string>): void {
  const ruleName = strName(rule.name);
  if (ruleName) validations.add(ruleName);
  if (isRec(rule.then)) collectValidationRuleNames(rule.then, validations);
  if (isRec(rule.otherwise)) collectValidationRuleNames(rule.otherwise, validations);
}

This mirrors evaluateRule's recursion (checkConditional dispatches the branch back through evaluateRule, which recurses into checkConditional again for a nested conditional) — depth is unbounded, matching the runtime.

The wrapper's own name stays in the universe, unchanged. Its message is structurally unreachable (checkConditional either returns nothing, returns unevaluableRuleError — which builds its own sentence — or delegates to the branch), so an entry for it is inert at runtime. #14518 keeps one anyway, deliberately, so the bundle mirrors the declared rule set 1:1 rather than re-deriving objectql's dispatch — this PR does not touch that decision.

packages/objectql/** is untouched: checkConditional / authoredRuleMessage are the addressing this mirrors, not changes.

Before / after (reproduces the card's own measurement)

Same fixture as the issue — demo_account with one conditional rule (churn_reason_consistency) whose then / otherwise are churn_reason_present / churn_reason_absent, and a bundle with entries for all three names:

Reproduced by importing validateTranslationReferences directly (via tsx) from a comparison worktree checked out at the pre-fix commit and from this branch, against the identical fixture object — not just asserted in a test, run both ways.

Fixtures added (validate-translation-references.test.ts, new describe block #14700)

All 64 tests in the file pass, including the pre-existing object-branch coverage vs the schema (#13835) pin, which still asserts one working leg per ObjectTranslationDataSchema key including _validations.

Gates

• pnpm --filter @objectstack/lint test — 93 test files / 2845 passed, 5 skipped (pre-existing skips, unrelated).
• pnpm --filter @objectstack/lint typecheck — clean (tsc --noEmit + check:test-typecheck).
• eslint --no-inline-config on both touched files — 0 errors / 0 warnings.
• node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --ran <record> at 413167ed8c (post-merge-of-main) — 34 derived, 30 run (all green), 4 NOT-MEASURED, 0 UNRUN:
  • check-test-completeness — grades a saved turbo run test log; none exists locally (CI tees one).
  • check-half-states (plain, live sweep) — timed out at 180s reaching GitHub through the session proxy; report-only, never fails a build (its own header says so); the check:pm-half-states self-test alias ran and passed.
  • check:dual-build-cjs-loads — reads built dist/ across ~80 workspace packages; full pnpm build not run in this worktree.
  • check:type-check-debt — --re-measure refuses without the full package build closure, by design (a number measured without it would count a different world, per its own message).

None of the 4 relate to this diff's file surface (packages/lint/src/validate-translation-references.{ts,test.ts}); all are repo-wide gates whose local prerequisite is a full monorepo build/test run, which CI performs.

Changeset

.changeset/nested-conditional-validation-refs.md — @objectstack/lint patch.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV

Generated by Claude Code