Skip to content

docs(qa): three approvals-checklist knownGap texts cite the retired backfill-account-issuer.ts #17453

Description

@hotlong

Three knownGap texts in docs/qa/platform-checklist/areas/approvals.json cite a file that no longer exists.

Each is marked [CLOSED by #9308 fixture 1 — the gap text stays because it carries the reason] and explains the historical trap by pointing at:

packages/plugins/plugin-auth/src/backfill-account-issuer.ts, CREDENTIAL_ISSUER

That module retired with sys_account.issuer when the platform adopted better-auth's account-issuer rollback. The texts also describe the showcase seed as deriving the credential issuer from the dev admin's row, which it no longer does — the derivation, its failure branch and the whole silent-lockout class went with the column.

Occurrences (line numbers as of the retirement PR):

  • docs/qa/platform-checklist/areas/approvals.json:23
  • docs/qa/platform-checklist/areas/approvals.json:259
  • docs/qa/platform-checklist/areas/approvals.json:662

Why this was not fixed in the retirement PR

The convention on those entries is explicit — the gap text stays because it carries the reason — so the right rewrite is a judgment call about historical record, not a mechanical path substitution. That is a different kind of decision from the retirement itself, and it belongs to whoever owns the checklist's conventions.

⛔ No gate is red on this: check:doc-authoring and check:docs both pass, so nothing will catch it later either.

What a fix probably looks like

Keep the reason (a password hash alone was not enough, and the failure mode was a silent lockout with a warn pointing at the wrong row), and record that the trap is now gone rather than pointing readers at a deleted module. A reader who follows the current text goes looking for a file that is not there and cannot tell whether the gap is closed or the citation merely rotted.

Blocked-by: #17440


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions