Skip to content

finding: two consumer-local structural DataEngineLike re-declarations remain after the #11493 deletion (datasource-admin-plugin, service-analytics) #11833

Description

@os-warren

Found while carrying out #11493 (which deleted service-datasource/src/plugin.ts's structural DataEngineLike per the maintainer ruling there). Filed unassigned as an observation, measured at eab6d131b.

The observation

Two more consumer-local structural engine types survive in-tree, same pattern the #4251 B3 sweep replaced with declared contract members ("seven consumer-local surface declarations"):

What was verified (and what was not)

Why it may deserve a card (and why not now)

The #11493 four-facet reasoning applies one seam over: a private structural type meets no compiler on the producer side, so engine-surface drift lands silently in the consumer. But both sites are deliberate graceful-degradation seams (absent members degrade to in-memory / reduced capability), and moving them to Partial<IObjectQLEngine>-style derived types or new optional contract members is a design decision with its own blast radius — needs its own pass, not a rider.

Refs: #11493 (the ruling + the deleted third instance) · #4251 (B3 — the declared-contract sweep this pattern predates/escaped).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions