Skip to content

Add --pass-refresh-token #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add --pass-refresh-token #3217

wants to merge 2 commits into from
+204 −24

Conversation

@carillonator
Copy link

@carillonator carillonator commented Sep 30, 2025 •
edited
Loading

Description

Add --pass-refresh-token option, copied almost verbatim from --pass-access-token.

Motivation and Context

Fixes #3216

This will help support offline access.

How Has This Been Tested?

Updated tests to be more generic and include refresh and ID tokens.

Also built a docker image, ran locally and confirmed works.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

@carillonator carillonator requested a review from a team as a code owner September 30, 2025 19:03
@william-will-angi
Copy link

william-will-angi commented Sep 30, 2025

I think the intent of this project is to move away from CLI args and towards alpha config. You can accomplish this with an alpha config:

injectResponseHeaders:
  - name: X-Auth-Refresh-Token
    values:
      - claim: refresh_token

@carillonator
Copy link
Author

carillonator commented Sep 30, 2025

I think the intent of this project is to move away from CLI args and towards alpha config. You can accomplish this with an alpha config:

injectResponseHeaders:
  - name: X-Auth-Refresh-Token
    values:
      - claim: refresh_token

@william-will-angi thanks, but we are not comfortable running in alpha mode, having been burned by bugs in the past, and we need a stable interface for production systems

@Antvirf
Copy link

Antvirf commented Oct 15, 2025

Super useful, looking forward to seeing this merged!

@tuunit
Copy link
Member

tuunit commented Oct 28, 2025

Hi @carillonator as @william-will-angi mentioned we are moving forward with the alpha config. I want to get the alpha to beta by the end of this year. Therefore we are not going to introduce additional legacy flags in the next couple of weeks / months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs go tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Option to pass refresh token upstream

4 participants

@carillonator @william-will-angi @Antvirf @tuunit