Sunset argument passed in property deprecation#792
Closed
jainsachi88 wants to merge 0 commit intooasdiff:mainfrom
Closed
Sunset argument passed in property deprecation#792jainsachi88 wants to merge 0 commit intooasdiff:mainfrom
jainsachi88 wants to merge 0 commit intooasdiff:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
=======================================
Coverage 89.55% 89.55%
=======================================
Files 239 239
Lines 12154 12154
=======================================
Hits 10884 10884
Misses 840 840
Partials 430 430
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect when properties in request/response bodies become deprecated, with sunset date validation.
Changes:
Files : Modified with date argument,
checker/check_request_property_deprecation.go
checker/check_response_property_deprecation.go
Example outputs:
With sunset: "request-property-deprecated with sunset date(2026-12-31)"
With Invalid/Missing sunset: "request-property-deprecated without/missing sunset date"