Conversation
This was referenced Sep 14, 2026
jusabe-kreditz
added a commit
to jusabe-kreditz/runtime
that referenced
this pull request
Sep 14, 2026
Date defines UnmarshalText, which parses the "2006-01-02" DateFormat, but
has no MarshalText, so it inherits time.Time's RFC 3339 one. Every codec
that pairs encoding.TextMarshaler with encoding.TextUnmarshaler therefore
writes a Date it cannot read back:
xml.Marshal -> <date>2019-04-01T00:00:00Z</date>
xml.Unmarshal -> parsing time "2019-04-01T00:00:00Z": extra text: "T00:00:00Z"
Format with DateFormat instead, matching MarshalJSON, String and
UnmarshalText, and matching the method set types.Duration already carries.
This also resolves the XML round trip that oapi-codegen#58 addressed with MarshalXML
and UnmarshalXML, without needing the encoding/xml import.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.