Generate names with initialisms#749
Merged
deepmap-marcinr merged 4 commits intooapi-codegen:masterfrom Oct 22, 2022
Merged
Conversation
wtertius
force-pushed
the
generate_names_with_initialisms
branch
from
664f246 to
74d13ef
Compare
Contributor
|
While it's nice to be consistent with initialisms, I generally feel it's not worth changing the code generation behavior for things like this, because lots of people will need to update their code once it breaks, or we need to flagify this fix to be optional. |
Contributor
|
Does it not default to the current behaviour, and only a config change will break things, which is expected? |
Contributor
|
Sorry, looked too fast. I resolved a bunch of conflicts (hopefully correctly). Thanks for the fix. |
Contributor
|
Sorry, I had to revert, because some initialisms broke in the existing code, and I had compiler errors. I'm happy to merge this, once it doesn't break existing code (or maybe I merged conflicts improperly). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support of two naming styles:
MyHTTPHandlerForAPIMyHttpHandlerForApiBy the steps of #715.