Chi-server wrapping middleware logic fix.#688
Closed
juddbaguio wants to merge 1 commit intooapi-codegen:masterfrom
Closed
Chi-server wrapping middleware logic fix.#688juddbaguio wants to merge 1 commit intooapi-codegen:masterfrom
juddbaguio wants to merge 1 commit intooapi-codegen:masterfrom
Conversation
Contributor
|
Hmm, interesting, so we process them in reverse order. This will reverse processing order for anyone who regenerates their code. |
Author
|
Exactly, we need to execute the right order of middlewares, this might also cause confusion to the devs who came from the Node.js background. |
Contributor
|
+1 FYI, |
Member
|
Thanks for this, looks like we got it finished in #787! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation server middlewares to a handler goes like this:
The snippet above tends to execute beginning middlewares at the later than the last ones.
The looping is supposed to be like this:
The solution is referenced from Ardan Lab's Service repository on wrapping middlewares