Fix readonly+required property#605
Merged
deepmap-marcinr merged 2 commits intooapi-codegen:masterfrom Jul 25, 2022
Merged
Conversation
florentchauveau
force-pushed
the
fix-readonly-required
branch
3 times, most recently
from
058bbfb to
5f2116a
Compare
florentchauveau
force-pushed
the
fix-readonly-required
branch
from
513d7d1 to
f542a2f
Compare
florentchauveau
force-pushed
the
fix-readonly-required
branch
4 times, most recently
from
c91f581 to
34b3268
Compare
glrf
added a commit
to projectsyn/lieutenant-api
that referenced
this pull request
Jul 29, 2022
This version introduces many breaking changes, but the old code gen behaviour can be restored with the correct configuration. However there is currently a bug, preventing us from completely switching back to the old behaviour. The provided config should generate equivalent code as soon as oapi-codegen/oapi-codegen#605 is released.
Closed
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
…ters (oapi-codegen#605) This fixes oapi-codegen#604. Co-authored-by: Marcin Romaszewicz <47459980+deepmap-marcinr@users.noreply.github.com>
bastjan
pushed a commit
to projectsyn/lieutenant-api
that referenced
this pull request
May 24, 2024
This version introduces many breaking changes, but the old code gen behaviour can be restored with the correct configuration. However there is currently a bug, preventing us from completely switching back to the old behaviour. The provided config should generate equivalent code as soon as oapi-codegen/oapi-codegen#605 is released.
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
…ters (oapi-codegen#605) This fixes oapi-codegen#604. Co-authored-by: Marcin Romaszewicz <47459980+deepmap-marcinr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #604. Properties that are both readonly and required should not be pointers on server-side code. Also, they should not be marked as "omitEmpty".