Improve gin support (interface, error, middlewares) - #530
Merged
1 commit merged intoApr 19, 2022
Merged
Conversation
mistermelphin
pushed a commit
to mistermelphin/oapi-codegen
that referenced
this pull request
Apr 6, 2022
Use gin.IRouter interface instead of *gin.Engine Switch custom middleware code to gin middleware Original changes: oapi-codegen#530
Contributor
|
Hey, this is neat but it ended throwing off how we were constructing the gin engine, looks like now the pattern needs to be: // Register the business logic handlers
apiRoutes := api.RegisterHandlers(r, apiServer).(*gin.RouterGroup)
r.Use(apiRoutes.Handlers...)Instead of what was previously: // Register the business logic handlers
r := api.RegisterHandlers(r, apiServer)I'm gonna submit a MR to update the Gin example since this new patch breaks the example. |
|
returning concrete types should be preferred over returning interfaces as concrete types that implement an interface may provide more functionality than the interface. |
|
huh, yeah. Agreed, returning concrete types is better. I missed that. I wonder whether to roll back this change. I hate breaking existing code like this. |
Contributor
|
We could update it to return a |
jazware
added a commit
to jazware/oapi-codegen
that referenced
this pull request
Apr 19, 2022
The most recent release of `oapi-codegen` (v1.10.0) included changes that broke the existing examples which were introduced in oapi-codegen#530 This change updates the `gin` example by regening the code-generated files and updating the router registration to work with the new generated code.
|
release a new minor version and retract the last one maybe in go.mod? |
This was referenced Apr 19, 2022
ghost
pushed a commit
that referenced
this pull request
Apr 19, 2022
This reverts commit 11622c2. It caused a breaking change to existing users.
ghost
pushed a commit
that referenced
this pull request
May 4, 2022
The most recent release of `oapi-codegen` (v1.10.0) included changes that broke the existing examples which were introduced in #530 This change updates the `gin` example by regening the code-generated files and updating the router registration to work with the new generated code.
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
Co-authored-by: Zihao Zhang <z@zeet.co>
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
This reverts commit f10cd14. It caused a breaking change to existing users.
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
The most recent release of `oapi-codegen` (v1.10.0) included changes that broke the existing examples which were introduced in oapi-codegen#530 This change updates the `gin` example by regening the code-generated files and updating the router registration to work with the new generated code.
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
Co-authored-by: Zihao Zhang <z@zeet.co>
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
This reverts commit 11622c2. It caused a breaking change to existing users.
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
The most recent release of `oapi-codegen` (v1.10.0) included changes that broke the existing examples which were introduced in oapi-codegen#530 This change updates the `gin` example by regening the code-generated files and updating the router registration to work with the new generated code.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will allow us to support nested router mounting using engine/routergroup/other routers
fixes Support RouterGroup when registering handlers with gin #507
the custom middleware code doesn't support context abort or c.Next() in normal gin middleware, this also fixes gin: abort request in case middleware function called abort #494 gin: included middleware cannot abort request #485
huge fix for debugging authentication func. before this change the nested e.Errors[] is completely hidden not surfaced anywhere.