fix(response): added an option to override the response suffix#493
Merged
deepmap-marcinr merged 2 commits intooapi-codegen:masterfrom May 14, 2022
Merged
fix(response): added an option to override the response suffix#493deepmap-marcinr merged 2 commits intooapi-codegen:masterfrom
deepmap-marcinr merged 2 commits intooapi-codegen:masterfrom
Conversation
This should resolve oapi-codegen#386 which is still an issue for clients, the changes in oapi-codegen#436 fixed it for types and server but not clients. This small change enables users to override the suffix where it could clash with existing names.
wolfeidau
force-pushed
the
fix_response_name
branch
from
d5cf64d to
bc864d2
Compare
|
@deepmap-marcinr Any chance this can get pulled into the next release. My team is running into the same issue that this resolves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve #386 which is still an issue for clients, the changes in #436 fixed it for types and server but not clients.
This small change enables users to override the suffix where it could clash with existing names.
I have updated the client template to ensure use of the provided suffix.