gin-server support - #385
Conversation
|
I'd love to use this! |
| } | ||
| {{end}} | ||
| {{if .IsStyled}} | ||
| err = runtime.BindStyledParameter("{{.Style}}",{{.Explode}}, "{{.ParamName}}", c.Query("{{.ParamName}}"), &{{$varName}}) |
There was a problem hiding this comment.
Should this be c.Param not c.Query?
| for _, middleware := range siw.HandlerMiddlewares { | ||
| middleware(c) | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe you want a IsAborted check to prevent the handler from being executed if the middleware aborts?
|
Thanks for your great contribution, any update about this PR ? |
|
Hi @TheTeaParty, is this PR still active? |
|
Hi guys, I am be really interested by this PR ^^ What are the blocking points ? Cheers, |
|
|
||
| // Options defines the optional code to generate. | ||
| type Options struct { | ||
| GenerateGinServer bool // GenerateChiServer specifies whether to generate chi server boilerplate |
There was a problem hiding this comment.
nit. GenerateChiServer should be GenerateGinServer
| return buf.String(), nil | ||
| } | ||
|
|
||
| // GenerateChiServer This function generates all the go code for the ServerInterface as well as |
There was a problem hiding this comment.
nit. GenerateChiServer should be GenerateGinServer
|
@TheTeaParty Great PR, love to see it merged in.. any work pending? |
|
Thanks for this! Just doing some cleanup, and it's now part of the library, although we didn't get around to using your contribution |
6 participants
Closes #384