Create non-pointer map/slice fields from optional properties#382
Create non-pointer map/slice fields from optional properties#382karupanerura wants to merge 4 commits intooapi-codegen:mainfrom
Conversation
|
I'd love to see this go in. Is there an issue blocking merge? If so, can I help? The build failure appears to come from the main branch. |
|
Thank you. I think you are right, the build failure appears to come from the main branch. |
ckarenz
left a comment
There was a problem hiding this comment.
Tagging @deepmap-marcinr for approval/merge.
IMO this is a fantastic change and worth the break.
|
@deepmap-marcinr is this will be merged? |
|
@deepmap-marcinr is there any updates on this change? |
|
This will break existing generated code. I've taken the approach of making these kinds of changes changed by flag. Your change moves the decision from templates ( Whenever changes liek this go in, they cause some hate mail. |
|
@deepmap-marcinr Would it be an option to introduce an extended property such as |
|
Is there any interest in this PR? I just bumped into this and would like to get it sorted. @karupanerura do you have any interest in doing the change yourself? Should I fork the PR and send an upgraded one to address anything else required to merge it? Thank you? |
|
@dlsniper Sorry for the late reply. I'm happy if you fork from this branch. I don't have enough time to solve the problem for a while. |
|
Thank you for contributing, and I'm very sorry for taking so long to get to this PR. At this point, the code has changed so much that it's no longer relevant because the |
Partially resolves #266.
No support for string, as it is still under discussion.
map/slice can represent nil without making it a pointer, so this patch should be able to resolve the issue about for map/slice.