Fix client request url construction when colon in path#313
Fix client request url construction when colon in path#313deepmap-marcinr merged 2 commits intooapi-codegen:masterfrom bvwells:312
Conversation
|
@deepmap-marcinr thanks for the review and merge! |
|
Unfortunately, this breaks cases when a request parameter contains '/'. Earlier, this got escaped well, now an argument of 'main/i' gets escaped as: |
|
@rkojedzinszky can you provide an example spec and I'll take a look. Could you also let me know which version of oapi-codegen you were previously using please? |
|
@bvwells I used latest, v1.5.2. The spec is a freenas 11.3 openapi, attached. For example, at path |
This reverts commit 720dae1. It broke path handling in a different way. We will fix this differently.
|
I've got a fix for this which does what @bvwells did in the client, but he missed the corresponding server side change to unescape arguments, so I fixed that side as well. Your code used to work @rkojedzinszky because we got lucky to be consistently wrong :) |
|
Sorry for missing this on the server side. Glad we got to the bottom of it as I couldn't work out what was wrong client side. |
…codegen#313)" This reverts commit 6120688. It broke path handling in a different way. We will fix this differently.
…codegen#313)" This reverts commit 720dae1. It broke path handling in a different way. We will fix this differently.
3 participants
Fix client request url construction when colon in path. Fixes issue #312.